Fix race in softnavs WPT interaction-with-paint-before-back.tentative.html.#52259
Merged
Conversation
….html. Same pattern as cr/6499490: We should create the promise before the click, so that we don't miss the softnavs perf entry. I'm thinking this means we can re-enable the test in the expectations. Change-Id: Ie6ffbc9eea4319ce1a6e12ef262459aab550681b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6500153 Reviewed-by: Annie Sullivan <sullivan@chromium.org> Commit-Queue: Johannes Henkel <johannes@chromium.org> Cr-Commit-Position: refs/heads/main@{#1453644}
wpt-pr-bot
approved these changes
Apr 30, 2025
Collaborator
wpt-pr-bot
left a comment
wpt-pr-bot
left a comment
There was a problem hiding this comment.
The review process for this patch is being conducted in the Chromium project.
Contributor
Unstable resultsTest | Subtest | Results | Messages -- | -- | -- | -- /soft-navigation-heuristics/interaction-with-paint-before-back.tentative.html | | ERROR: 2/10, TIMEOUT: 8/10 |These may be pre-existing or new flakes. Please try to reproduce (see the above WPT command, though some flags may not be needed when running locally) and determine if your change introduced the flake. If you are unable to reproduce the problem, please tag |
Contributor
|
@jcscottiii @DanielRyanSmith This is another softnavs WPT. pls help admin merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Same pattern as cr/6499490: We should create the promise before
the click, so that we don't miss the softnavs perf entry.
I'm thinking this means we can re-enable the test in the
expectations.
Change-Id: Ie6ffbc9eea4319ce1a6e12ef262459aab550681b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6500153
Reviewed-by: Annie Sullivan <sullivan@chromium.org>
Commit-Queue: Johannes Henkel <johannes@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1453644}