Check if percentages are resolvable in CSSParserLocalContext#57778
Merged
Conversation
Let CSSParserLocalContext check whether percentages can be resolved without used value information or not for the specified property. Since some color functions, like color-mix(), shape or transform functions has their own context when resolving percentages, some of the properties may have both, percentages that depend on a used value and percentages that don't (for instance, inside some color function), we need to keep track whether we are currently parsing values inside some css function. CSSParserLocalContext keep track of that by maintaining a stack of the current parsed functions. Note: the border-image-slice test fails since we expect only simplified percentages and not `kCalcLengthFunction` for that property. To be fixed in next CL. Bug: 413385732 Change-Id: I937675f2d8e138fc3e23cc401e313eed3dc86b3c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7544868 Commit-Queue: Munira Tursunova <moonira@google.com> Reviewed-by: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/main@{#1584580}
wpt-pr-bot
approved these changes
Feb 13, 2026
Collaborator
wpt-pr-bot
left a comment
wpt-pr-bot
left a comment
There was a problem hiding this comment.
The review process for this patch is being conducted in the Chromium project.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Let CSSParserLocalContext check whether percentages can be resolved
without used value information or not for the specified property. Since
some color functions, like color-mix(), shape or transform functions has
their own context when resolving percentages, some of the properties may
have both, percentages that depend on a used value and percentages that
don't (for instance, inside some color function), we need to keep track
whether we are currently parsing values inside some css function.
CSSParserLocalContext keep track of that by maintaining a stack of the
current parsed functions.
Note: the border-image-slice test fails since we expect only simplified
percentages and not
kCalcLengthFunctionfor that property. To be fixedin next CL.
Bug: 413385732
Change-Id: I937675f2d8e138fc3e23cc401e313eed3dc86b3c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7544868
Commit-Queue: Munira Tursunova <moonira@google.com>
Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1584580}