WebVTT: HTML entity inside voice annotation#59331
Merged
Merged
Conversation
annevk
added a commit
to annevk/WebKit
that referenced
this pull request
Apr 18, 2026
https://bugs.webkit.org/show_bug.cgi?id=312686 rdar://175084171 Reviewed by NOBODY (OOPS!). The WebVTT cue text tokenizer was using InputStreamPreprocessor, which replaced U+0000 NULL with U+FFFD. This was wrong for getCueAsHTML(). So instead we use StringParsingBuffer, which preserves all characters as-is. We also fix a pre-existing bug where entity-decoded characters in voice annotations (e.g., <v Foo&Bar>) were appended to the tag name instead of the annotation text, and unskip five already-passing rendering tests. Upstream: web-platform-tests/wpt#59331
annevk
added a commit
to annevk/WebKit
that referenced
this pull request
Apr 18, 2026
https://bugs.webkit.org/show_bug.cgi?id=312686 rdar://175084171 Reviewed by NOBODY (OOPS!). The WebVTT cue text tokenizer was using InputStreamPreprocessor, which replaced U+0000 NULL with U+FFFD. This was wrong for getCueAsHTML(). So instead we use StringParsingBuffer, which preserves all characters as-is. We also fix a pre-existing bug where entity-decoded characters in voice annotations (e.g., <v Foo&Bar>) were appended to the tag name instead of the annotation text, and unskip five already-passing rendering tests. Upstream: web-platform-tests/wpt#59331
annevk
added a commit
to annevk/WebKit
that referenced
this pull request
Apr 18, 2026
https://bugs.webkit.org/show_bug.cgi?id=312686 rdar://175084171 Reviewed by NOBODY (OOPS!). The WebVTT cue text tokenizer was using InputStreamPreprocessor, which replaced U+0000 NULL with U+FFFD. This was wrong for getCueAsHTML(). So instead we use StringParsingBuffer, which preserves all characters as-is. We also fix a pre-existing bug where entity-decoded characters in voice annotations (e.g., <v Foo&Bar>) were appended to the tag name instead of the annotation text, and unskip five already-passing rendering tests. Upstream: web-platform-tests/wpt#59331
webkit-commit-queue
pushed a commit
to annevk/WebKit
that referenced
this pull request
Apr 19, 2026
https://bugs.webkit.org/show_bug.cgi?id=312686 rdar://175084171 Reviewed by Chris Dumez. The WebVTT cue text tokenizer was using InputStreamPreprocessor, which replaced U+0000 NULL with U+FFFD. This was wrong for getCueAsHTML(). So instead we use StringParsingBuffer, which preserves all characters as-is. We also fix a pre-existing bug where entity-decoded characters in voice annotations (e.g., <v Foo&Bar>) were appended to the tag name instead of the annotation text, and unskip five already-passing rendering tests. Upstream: web-platform-tests/wpt#59331 Canonical link: https://commits.webkit.org/311539@main
noamr
approved these changes
Apr 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.