[Connection-Allowlist] Enforce "webrtc" header param.#59539
Merged
Conversation
WebRTC needs to be treated specially by the Connection-Allowlist header, because it is not possible to enumerate hostnames that will be used for P2P connections. The decision was made in WICG/connection-allowlists#6 to use a global header flag that will either completely allow or block WebRTC peer connections, regardless of the target origin. This was specified in WICG/connection-allowlists@5b5fcb5. and this CL implements the enforcement portion of the specification. Note that there are changes in both the renderer and the browser. * On the renderer side, we prevent construction of RTCPeerConnection. * On the browser side, we prevent the P2PSocketManager from being bound in the network service, as an extra layer of protection against a compromised renderer. This is similar to how P2P was handled for fenced frames. Bug: 492439214 Change-Id: Ib10bda11020df74e3ecd41450027cacbf6a7bd2a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7676321 Reviewed-by: Mike West <mkwst@chromium.org> Commit-Queue: Andrew Verge <averge@chromium.org> Reviewed-by: Johannes Kron <kron@chromium.org> Cr-Commit-Position: refs/heads/main@{#1622470}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-7676321
branch
from
ce91be2 to
a4b5829
Compare
wpt-pr-bot
approved these changes
Apr 29, 2026
Collaborator
wpt-pr-bot
left a comment
wpt-pr-bot
left a comment
There was a problem hiding this comment.
The review process for this patch is being conducted in the Chromium project.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WebRTC needs to be treated specially by the Connection-Allowlist header,
because it is not possible to enumerate hostnames that will be used for
P2P connections.
The decision was made in
WICG/connection-allowlists#6 to use a global
header flag that will either completely allow or block WebRTC peer
connections, regardless of the target origin.
This was specified in
WICG/connection-allowlists@5b5fcb5.
and this CL implements the enforcement portion of the specification.
Note that there are changes in both the renderer and the browser.
in the network service, as an extra layer of protection against a
compromised renderer. This is similar to how P2P was handled for
fenced frames.
Bug: 492439214
Change-Id: Ib10bda11020df74e3ecd41450027cacbf6a7bd2a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7676321
Reviewed-by: Mike West <mkwst@chromium.org>
Commit-Queue: Andrew Verge <averge@chromium.org>
Reviewed-by: Johannes Kron <kron@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1622470}