Fix for passing dot as splitcharacter to RegExp constructor #297
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| } | ||
|
|
||
| function escapeForRegExp(value: string): string { | ||
| return value.replace(/[.*+?^${}()|[\]\\]/g, '\\$&') |
Contributor
Author
There was a problem hiding this comment.
dot is the only special character that is used here for splitCharacter. I added all special characters here because maybe this can be abstracted to util in the future and used in other places. If you prefer to have only ., I can change this.
Contributor
Author
There was a problem hiding this comment.
Member
|
@pragatheeswarans I'm don't fully understand of what is going on but LGTM! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:
When the locale of the DatePickerInput component is set to "de" (German), the functionality to add an automatic date separator ("." in the case of the German locale) is broken. Instead of appending a dot to the first two characters entered, the input gets changed to a single dot. Subsequently, any numbers entered are concatenated without the proper separator.
Solution:
I found the usage of the
RegExpconstructor to create regular expressions. One of the supported date separator is.(dd.mm.yyyy). Thedotcharacter is ametacharacterin regular expressions which needs to be escaped if it is being passed into theRegExpconstructor. In this code block, it was not escaped. Hence the codeyielded a different regex than the expected one.
Fixes DatePickerInput component breaks automatic date separator when setting locale to "de"