Skip to content

Fix for passing dot as splitcharacter to RegExp constructor #297

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 22, 2023
Merged

Fix for passing dot as splitcharacter to RegExp constructor #297

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion src/TextInputMask.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,10 @@ function detectCharacter(mask: string): string {
return c || ''
}

function escapeForRegExp(value: string): string {
return value.replace(/[.*+?^${}()|[\]\\]/g, '\\$&')
Copy link
Contributor Author

@pragatheeswarans pragatheeswarans Jun 20, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dot is the only special character that is used here for splitCharacter. I added all special characters here because maybe this can be abstracted to util in the future and used in other places. If you prefer to have only ., I can change this.

Copy link
Contributor Author

@pragatheeswarans pragatheeswarans Jun 20, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From https://developer.mozilla.org/en-US/docs/Web/JavaScript/Guide/Regular_expressions#escaping

}

function TextInputWithMask(
{
onChangeText,
Expand Down Expand Up @@ -40,7 +44,7 @@ function TextInputWithMask(
)
const replaceValue = format.match(/\W/)
const replace = `$1${splitCharacter}$2${splitCharacter}$3$4`.replace(
new RegExp(splitCharacter, 'g'),
new RegExp(escapeForRegExp(splitCharacter), 'g'),
(replaceValue ?? '') as string
)

Expand Down