274 featconfig auto create configuration by network event#294
Merged
evgheni7 merged 2 commits intoApr 10, 2025
Merged
Conversation
2 tasks
evgheni7
requested changes
Apr 9, 2025
| func CreateConfiguration(ctx context.Context, logger *zap.SugaredLogger, msg crossplanev1beta1.MsgCreateConfiguration, config *rest.Config, dc *dynamic.DynamicClient, username string) { | ||
| packageEncrypted := msg.Spec.GetPackage() | ||
| aesKeyEncrypted := msg.Spec.GetAesKey() | ||
| token := os.Getenv("GITHUB_TOKEN") |
Contributor
There was a problem hiding this comment.
@Catalin4513 token if it exists shall be taken form chain event, not from env, what is sense to take it from env?
Catalin4513
force-pushed
the
274-featconfig-auto-create-configuration-by-network-event
branch
from
a076ac3 to
f67f78c
Compare
evgheni7
approved these changes
Apr 10, 2025
evgheni7
deleted the
274-featconfig-auto-create-configuration-by-network-event
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.