297 featbilling reconciliation event watching#301
Merged
Conversation
2 tasks
evgheni7
requested changes
Apr 30, 2025
Comment on lines
+21
to
+23
| kubeconfig := os.Getenv("KUBECONFIG") | ||
| if kubeconfig == "" { | ||
| kubeconfig = filepath.Join(os.Getenv("HOME"), ".kube", "config") | ||
| } | ||
|
|
||
| config, err := clientcmd.BuildConfigFromFlags("", kubeconfig) | ||
| if err != nil { | ||
| log.Fatalf("Error building kubeconfig: %v", err) | ||
| } | ||
| clientset, err := kubernetes.NewForConfig(config) | ||
| if err != nil { | ||
| log.Fatalf("Error creating Kubernetes client: %v", err) | ||
| } | ||
|
|
Contributor
There was a problem hiding this comment.
Get client from injected services, check how is done in other parts of app.
Catalin4513
force-pushed
the
297-featbilling-reconciliation-event-watching
branch
from
10c73dd to
1ca3a7b
Compare
evgheni7
requested changes
Apr 30, 2025
Contributor
evgheni7
left a comment
evgheni7
left a comment
There was a problem hiding this comment.
Move duplicate sources to main app from plugins, eg. checks of crossplane events, etc.
Catalin4513
force-pushed
the
297-featbilling-reconciliation-event-watching
branch
from
1ca3a7b to
4dcaf1b
Compare
evgheni7
approved these changes
May 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.