feat(basic/ts): add typescript basic react chef#42
Merged
Conversation
ramsunvtech
requested changes
Dec 12, 2025
Comment on lines
+2
to
+26
| return `import React from 'react' | ||
| import { BrowserRouter as Router } from 'react-router-dom' | ||
| import { createBrowserHistory } from 'history' | ||
|
|
||
| import Routes from './Routes' | ||
|
|
||
| // Block Components. | ||
| import { ErrorHandler, PageLoader } from './components/blocks' | ||
|
|
||
| import { withTranslation } from '@/${sourceDir.i18n}' | ||
|
|
||
| const browserHistory = createBrowserHistory() | ||
|
|
||
| function App() { | ||
| return ( | ||
| <ErrorHandler> | ||
| <PageLoader /> | ||
| <Router history={browserHistory}> | ||
| <Routes /> | ||
| </Router> | ||
| </ErrorHandler> | ||
| ) | ||
| } | ||
|
|
||
| export default withTranslation(App) |
Member
There was a problem hiding this comment.
these need to be typescript typed code
| function getSourceCode(appName, { sourceDir }) { | ||
| return `import React from 'react' | ||
| import { useNavigate } from 'react-router-dom' | ||
| import PropTypes from 'prop-types' |
Member
There was a problem hiding this comment.
getSourceCode returning code should be typed code.
| // UI Components. | ||
| import { Spinner } from '@/components/ui' | ||
|
|
||
| export default function PageLoader({ loading }) { |
| import { RoutePaths } from '@/utils' | ||
|
|
||
| // Lazy-loaded modules | ||
| const SignInModule = React.lazy(() => |
Member
There was a problem hiding this comment.
typed code is missing. its javascript
| // Utils. | ||
| import { RoutePaths } from '@/${sourceDir.utility}' | ||
|
|
||
| const Sidebar = (props) => { |
Member
There was a problem hiding this comment.
typed code is missing. its javascript
| @@ -0,0 +1,7 @@ | |||
| import React from 'react' | |||
|
|
|||
| const BlockLoader = ({ props }) => { | |||
Member
There was a problem hiding this comment.
typed code is missing. its javascript
| const [error, setError] = useState() | ||
| const [loading, setLoading] = useState(false) | ||
|
|
||
| useEffect(async () => { |
Member
There was a problem hiding this comment.
typed code is missing. its javascript
| function useOnlineStatus() { | ||
| const [online, setOnline] = useState(window.navigator.onLine) | ||
|
|
||
| useEffect(() => { |
Member
There was a problem hiding this comment.
typed code is missing. its javascript
| const [error, setError] = useState() | ||
| const [loading, setLoading] = useState(false) | ||
|
|
||
| const postData = async (payload) => { |
Member
There was a problem hiding this comment.
typed code is missing. its javascript
| // Utils. | ||
| import { RoutePaths } from '@/utils' | ||
|
|
||
| const NotFound = () => { |
Member
There was a problem hiding this comment.
typed code is missing. its javascript
ramsunvtech
requested changes
Dec 13, 2025
| "webpackLoaders", | ||
| "babel", | ||
| "basicTypescriptDev" | ||
|
|
| Sidebar: sidebarBlock, | ||
| TopBar: topBarBlock, | ||
| } | ||
|
|
Comment on lines
+222
to
+225
| if (isTypeScriptProjectType) { | ||
| const tsConfigFileName = `tsconfig.json`; | ||
| createFile(tsConfigFileName, getFileContent(tsConfigFileName)); | ||
| } |
Member
There was a problem hiding this comment.
this changes not required and its already exist in 226
Comment on lines
+257
to
+264
| let projectTypeName; | ||
| if (is_BasicTypeScriptProjectType) { | ||
| projectTypeName = 'basic'; | ||
| } else if (isSlimTypeScriptProject(projectType)) { | ||
| projectTypeName = 'slim'; | ||
| } else { | ||
| projectTypeName = projectType; | ||
| } |
Member
There was a problem hiding this comment.
can is_BasicTypeScriptProjectType rename to isBasicTypeScriptProjectType
ramsunvtech
requested changes
Dec 13, 2025
|
|
||
| const browserHistory: History = createBrowserHistory() | ||
|
|
||
| const App: React.FC = () => { |
Member
There was a problem hiding this comment.
try this below.
interface AppProps extends WithTranslation {}
const App: React.FC<AppProps> = (props) => {
Comment on lines
+15
to
+17
| interface DashboardProps { | ||
| title?: string | ||
| } |
Member
There was a problem hiding this comment.
this need to be separate file in types/dashboard.ts
Collaborator
Author
There was a problem hiding this comment.
Already this file after installation it will add inside module folder
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Basic TypeScript App on React Chef.