This repository was archived by the owner on Mar 5, 2025. It is now read-only.
Accept predefined block numbers for eth_feeHistory#4213
Merged
Spacesai1or merged 3 commits intoweb3:wyatt/eth_feeHistory-blocktagsfrom Aug 5, 2021
Merged
Accept predefined block numbers for eth_feeHistory#4213Spacesai1or merged 3 commits intoweb3:wyatt/eth_feeHistory-blocktagsfrom
Spacesai1or merged 3 commits intoweb3:wyatt/eth_feeHistory-blocktagsfrom
Conversation
Pull Request Test Coverage Report for Build 1081048064
💛 - Coveralls |
Contributor
|
I was mistaken on this, seems to be working for Geth |
Spacesai1or
added
Do Not Merge
Spacesai1or
removed
Do Not Merge
Spacesai1or
pushed a commit
that referenced
this pull request
Aug 5, 2021
* Accept predefined block numbers for eth_feeHistory (#4213) * Accept predefined block numbers for eth_feeHistory * Update feeHistory tests to reflect new input formatter Co-authored-by: Wyatt Barnes <wyatt@writerof.software> * Add block tag tests * Update CHANGELOG * Replace inputFormatter with null to match existing code Co-authored-by: brg8 <bgodlove88@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Allow the
eth_feeHistorymethod to accept predefined block numbers, e.g. "latest". This is the appropriate schema type as defined in the ethereum spec: https://github.com/ethereum/eth1.0-specs/blob/master/json-rpc/spec.json.The current behavior of forcing the parameter into
utils.toHexactually does convert "latest" into a hex far beyond head resulting in the node response of "request beyond head block" (for geth).Type of change
Checklist:
npm run dtslintwith success and extended the tests and types if necessary.npm run test:unitwith success.npm run test:covand my test cases cover all the lines and branches of the added code.npm run buildand testeddist/web3.min.jsin a browser.CHANGELOG.mdfile in the root folder.