Skip to content

fix: avoid true as GitHub username#953

Merged
AnrokX merged 1 commit intomainfrom
fix/gh-account-detection-true
Mar 20, 2026
Merged

fix: avoid true as GitHub username#953
AnrokX merged 1 commit intomainfrom
fix/gh-account-detection-true

Conversation

@AnrokX
Copy link
Copy Markdown
Collaborator

@AnrokX AnrokX commented Mar 20, 2026

Summary

  • tighten GitHub auth status parsing so Active account: true is never mistaken for the login
  • keep support for explicit account: and user: lines from gh auth status
  • add regression tests covering the rare true username case

Testing

  • npm run test:unit -- githubRepoService

@AnrokX AnrokX merged commit 6478177 into main Mar 20, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant