fix(windows): remove useConpty option causing PTY spawn failures#964
Merged
web3dev1337 merged 1 commit intomainfrom Mar 20, 2026
Merged
fix(windows): remove useConpty option causing PTY spawn failures#964web3dev1337 merged 1 commit intomainfrom
web3dev1337 merged 1 commit intomainfrom
Conversation
The bundled node-pty 1.2.0-beta.12 JS wrapper passes 7 args to conptyNative.startProcess() but the cached native conpty.node binary only accepts 6, causing every terminal spawn to fail with: "Usage: pty.startProcess(file, cols, rows, debug, pipeName, inheritCursor)" - Remove useConpty:true from buildPtyOptions and commanderService (ConPTY is already the default on modern Windows, and node-pty ignores this option anyway - it uses useConptyDll internally) - Bust CI cache key (v1 -> v2) to force fresh native binary rebuild Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
14 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Usage: pty.startProcess(file, cols, rows, debug, pipeName, inheritCursor)conptyNative.startProcess()but cachedconpty.nodebinary only accepts 6useConpty: truefrombuildPtyOptions()andcommanderService— ConPTY is already the default on modern Windows, and node-pty ignores this option (it usesuseConptyDllinternally)Test plan
🤖 Generated with Claude Code