Skip to content

fix(windows): make node-pty compat shim adaptive#975

Merged
web3dev1337 merged 2 commits intomainfrom
fix/windows-pty-compat-main
Mar 21, 2026
Merged

fix(windows): make node-pty compat shim adaptive#975
web3dev1337 merged 2 commits intomainfrom
fix/windows-pty-compat-main

Conversation

@web3dev1337
Copy link
Copy Markdown
Owner

Summary

  • make the Windows node-pty runtime shim try the native 7-argument startProcess call first
  • only retry without the 7th useConptyDll argument when the native binding throws the startProcess usage error
  • expand nodePtyCompat unit coverage to lock both working Windows source builds and stale packaged bindings

Why

The current runtime shim on main always drops the 7th argument for node-pty@1.2.0-beta.12. That rescues stale packaged bindings, but it breaks normal Windows source/test environments whose native module already expects all 7 arguments. That is what failed in the merged #974 Windows/unit run.

Verification

  • npm run test:unit -- tests/unit/nodePtyCompat.test.js tests/unit/sessionManager.windowsPty.test.js tests/unit/commanderService.windowsShellArgs.test.js
  • npm run test:unit

@web3dev1337 web3dev1337 merged commit 941f68c into main Mar 21, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant