fix(windows): patch packaged node-pty connect compat#977
Merged
web3dev1337 merged 1 commit intomainfrom Mar 21, 2026
Merged
Conversation
This was referenced Mar 21, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
node-ptyruntime compat shim beyondstartProcess()so stale packaged bindings also retryconnect()and related ConPTY boolean-tail methods with the legacy signatureswindowsPtyAgent.jspatcher to rewrite the brokenconptyNative.connect(...)call in bundled resources, not juststartProcess(...)Root cause
From the packaged Windows logs under
C:\Users\AB\AppData\Roaming\com.agent.workspace\logs:combined.logshowed the backend successfully bindinghttp://127.0.0.1:58490error.logthen showedUsage: pty.connect(id, cmdline, cwd, env, exitCallback)fromnode-pty/lib/windowsPtyAgent.jsThat means the Tauri bootstrap path was fine. The backend became reachable briefly, then crashed immediately because the bundled JS was still calling a newer ConPTY
connect()signature against an older native binding.Testing
node --check server/utils/nodePtyCompat.jsnode --check server/utils/processUtils.jsnode --check tests/unit/nodePtyCompat.test.jsnode --check tests/unit/sessionManager.windowsPty.test.jsnpm run test:unit -- tests/unit/nodePtyCompat.test.js tests/unit/sessionManager.windowsPty.test.js tests/unit/commanderService.windowsShellArgs.test.jsnpm run test:unit