Skip to content

Add settings for login triggers.#2

Merged
rheinardkorf merged 3 commits into
devfrom
feature/1-login-trigger
Dec 23, 2021
Merged

Add settings for login triggers.#2
rheinardkorf merged 3 commits into
devfrom
feature/1-login-trigger

Conversation

@rheinardkorf
Copy link
Copy Markdown
Collaborator

Resolves #1

  1. Adds a new setting in 'Web3 WP' options to specify a CSS class that will trigger the wallet to connect. Default: connect-wallet-link.

To test create a new element on the page (e.g. a menu item) and apply the desired CSS class to the element. Ensure that the element is set in the plugin options.

  1. Adds a new setting that will force a wallet connect on page load (current behaviour) or to keep it disabled.

@rheinardkorf rheinardkorf linked an issue Dec 22, 2021 that may be closed by this pull request
@rheinardkorf
Copy link
Copy Markdown
Collaborator Author

@uglyrobot there is just one more bug with this I need to check. Right now after you switch your wallet, you are asked to sign, but it doesn't log you in. Only after the second time you click connect.

Will re-request review when that is fixed.

@rheinardkorf
Copy link
Copy Markdown
Collaborator Author

Fixed. Ready for review.

@rheinardkorf rheinardkorf merged commit f6db86d into dev Dec 23, 2021
@rheinardkorf rheinardkorf deleted the feature/1-login-trigger branch December 23, 2021 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Create Login/Logout Triggers

1 participant