Skip to content

fix(hud): resolve overlay snap to primary on multi-monitor #207

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
webadderall merged 1 commit into from
Apr 9, 2026
Merged

fix(hud): resolve overlay snap to primary on multi-monitor #207

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 12 additions & 7 deletions electron/windows.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -165,9 +165,16 @@ function getScreen() {
return nodeRequire("electron").screen as typeof import("electron").screen;
}

function getHudOverlayDisplay() {
const hudWindow = getHudOverlayWindow();
if (hudWindow) {
return getScreen().getDisplayMatching(hudWindow.getBounds());
}
return getScreen().getPrimaryDisplay();
}

function getHudOverlayBounds(expanded: boolean) {
const primaryDisplay = getScreen().getPrimaryDisplay();
const { bounds, workArea } = primaryDisplay;
const { bounds, workArea } = getHudOverlayDisplay();
const maxWindowWidth = Math.max(HUD_MIN_WINDOW_WIDTH, workArea.width - HUD_EDGE_MARGIN_DIP * 2);
const windowWidth = Math.min(
maxWindowWidth,
Expand Down Expand Up @@ -318,10 +325,9 @@ ipcMain.on("set-hud-overlay-compact-width", (_event, width: number) => {
return;
}

const primaryDisplay = getScreen().getPrimaryDisplay();
const maxWindowWidth = Math.max(
HUD_MIN_WINDOW_WIDTH,
primaryDisplay.workArea.width - HUD_EDGE_MARGIN_DIP * 2,
getHudOverlayDisplay().workArea.width - HUD_EDGE_MARGIN_DIP * 2,
);
const nextWidth = Math.min(maxWindowWidth, Math.max(HUD_MIN_WINDOW_WIDTH, Math.round(width)));

Expand All @@ -338,10 +344,9 @@ ipcMain.on("set-hud-overlay-measured-height", (_event, height: number, expanded:
return;
}

const primaryDisplay = getScreen().getPrimaryDisplay();
const maxWindowHeight = Math.max(
HUD_COMPACT_HEIGHT,
primaryDisplay.workArea.height - HUD_EDGE_MARGIN_DIP * 2,
getHudOverlayDisplay().workArea.height - HUD_EDGE_MARGIN_DIP * 2,
);
const nextHeight = Math.min(maxWindowHeight, Math.max(HUD_COMPACT_HEIGHT, Math.round(height)));

Expand Down Expand Up @@ -399,7 +404,7 @@ export function createHudOverlayWindow(): BrowserWindow {
minHeight: HUD_COMPACT_HEIGHT,
maxHeight: Math.max(
HUD_COMPACT_HEIGHT,
getScreen().getPrimaryDisplay().workArea.height - HUD_EDGE_MARGIN_DIP * 2,
getHudOverlayDisplay().workArea.height - HUD_EDGE_MARGIN_DIP * 2,
),
x: initialBounds.x,
y: initialBounds.y,
Expand Down