fix: remove extension-sources, replace lucide-react with phosphor icons#263
Merged
webadderall merged 1 commit intomainfrom Apr 18, 2026
Merged
Conversation
- Remove extension-sources/ directory (91MB of bundled extension assets) - Add extension-sources/ to .gitignore - Replace all lucide-react imports with @phosphor-icons/react equivalents in TutorialHelp, ExtensionManager, and TimelineEditor - Fixes #261 (missing lucide-react dependency + Twitter icon crash) Closes #261
Contributor
|
Warning
|
| Cohort / File(s) | Summary |
|---|---|
Icon Library Migration src/components/video-editor/ExtensionManager.tsx, src/components/video-editor/TutorialHelp.tsx, src/components/video-editor/timeline/TimelineEditor.tsx |
Replaced lucide-react icon imports with @phosphor-icons/react equivalents via aliasing (e.g., ChevronLeft → CaretLeft, Loader2 → SpinnerGap, Download → DownloadSimple). No logic or control flow changes. |
Extension Removal extension-sources/insomniachooman.cool-cursors/*, extension-sources/webadderall.more-wallpapers/* |
Deleted two extension packages entirely, including both index.js activation modules and recordly-extension.json manifest files. No replacement or equivalent functionality added. |
Git Configuration .gitignore |
Updated line-ending formatting to Windows-style CRLF, added extension-sources/ to ignore patterns, and restored previously removed entries (vite.config.js, build artifacts, debug scripts). |
Estimated code review effort
🎯 1 (Trivial) | ⏱️ ~3 minutes
Possibly related PRs
- feat: settings tab with language picker, extension fixes, and i18n expansion #249: Performs the same icon library migration from
lucide-reactto@phosphor-icons/reactwith matching icon name remappings across multiple components. - Revert "feat: Advanced Video Editor Implementation, Native WGC Integration, and AI Auto-Captions" #124: Modifies the same video-editor component files (
ExtensionManager.tsx,TutorialHelp.tsx,TimelineEditor.tsx). - feat: add light mode theme support #258: Updates the same UI component files in
src/components/video-editor/with theme-related styling adjustments.
Suggested labels
Checked
Poem
🐰 Hoppy refactoring day!
Out go cursors, wallpapers away,
Icons swapped from lucide's array
To phosphor's brilliant display,
Our hop skips lighter today! ✨
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
| Check name | Status | Explanation |
|---|---|---|
| Title check | ✅ Passed | The title accurately summarizes the two main changes: removing extension-sources and replacing lucide-react with phosphor icons. |
| Description check | ✅ Passed | The description provides detailed summaries of both major changes, context about the dependency issue, and clarifies the separate Linux/GPU problem. |
| Linked Issues check | ✅ Passed | The PR directly addresses both coding requirements from #261: adding lucide-react to dependencies (by replacing with phosphor) and fixing the Twitter export crash. |
| Out of Scope Changes check | ✅ Passed | All changes are directly in scope: removing bundled extension assets, adding to .gitignore, and replacing icon libraries as required by #261. |
| Docstring Coverage | ✅ Passed | No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. |
✏️ Tip: You can configure your own custom pre-merge checks in the settings.
✨ Finishing Touches
📝 Generate docstrings
- Create stacked PR
- Commit on current branch
🧪 Generate unit tests (beta)
- Create PR with unit tests
- Commit unit tests in branch
fix/remove-extension-sources-fix-lucide
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Comment @coderabbitai help to get the list of available commands and usage tips.
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
🧹 Nitpick comments (1)
.gitignore (1)
1-5: Add.gitattributesto enforce consistent line endings across platforms.The
.gitignorefile currently has CRLF (Windows-style) line endings, and no.gitattributesfile exists to enforce consistency. Since this is a cross-platform Electron app (targeting Windows, macOS, and Linux), this can cause spurious diffs and merge conflicts when developers on different platforms edit the file.Add a
.gitattributesfile with:* text=auto .gitignore text eol=lfThis ensures that
.gitignoreis checked out with consistent LF line endings regardless of the developer's platform.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In @.gitignore around lines 1 - 5, Add a new .gitattributes file to enforce LF line endings for the repository and ensure .gitignore is normalized across platforms; create a file named .gitattributes at repo root containing the directives to treat files as text and to force .gitignore to use LF (e.g., include lines to set "* text=auto" and ".gitignore text eol=lf"), commit that alongside the existing .gitignore so editors on Windows/macOS/Linux check out consistent line endings.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In @.gitignore:
- Around line 1-5: Add a new .gitattributes file to enforce LF line endings for
the repository and ensure .gitignore is normalized across platforms; create a
file named .gitattributes at repo root containing the directives to treat files
as text and to force .gitignore to use LF (e.g., include lines to set "*
text=auto" and ".gitignore text eol=lf"), commit that alongside the existing
.gitignore so editors on Windows/macOS/Linux check out consistent line endings.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro
Run ID: abf6a567-0c5f-4d4c-b200-97f67f52a2b6
⛔ Files ignored due to path filters (192)
extension-sources/insomniachooman.cool-cursors/cursors/amongus/default.pngis excluded by!**/*.pngextension-sources/insomniachooman.cool-cursors/cursors/amongus/pointer.pngis excluded by!**/*.pngextension-sources/insomniachooman.cool-cursors/cursors/chooper/default.pngis excluded by!**/*.pngextension-sources/insomniachooman.cool-cursors/cursors/chooper/pointer.pngis excluded by!**/*.pngextension-sources/insomniachooman.cool-cursors/cursors/lavender/default.pngis excluded by!**/*.pngextension-sources/insomniachooman.cool-cursors/cursors/lavender/pointer.pngis excluded by!**/*.pngextension-sources/insomniachooman.cool-cursors/cursors/parched/default.pngis excluded by!**/*.pngextension-sources/insomniachooman.cool-cursors/cursors/parched/pointer.pngis excluded by!**/*.pngextension-sources/insomniachooman.cool-cursors/cursors/turtle/default.pngis excluded by!**/*.pngextension-sources/insomniachooman.cool-cursors/cursors/turtle/pointer.pngis excluded by!**/*.pngextension-sources/insomniachooman.cool-cursors/icon.pngis excluded by!**/*.pngextension-sources/webadderall.more-wallpapers/icon.pngis excluded by!**/*.pngextension-sources/webadderall.more-wallpapers/wallpapers/Energy/energy-1.jpgis excluded by!**/*.jpgextension-sources/webadderall.more-wallpapers/wallpapers/Energy/energy-10.jpgis excluded by!**/*.jpgextension-sources/webadderall.more-wallpapers/wallpapers/Energy/energy-11.jpgis excluded by!**/*.jpgextension-sources/webadderall.more-wallpapers/wallpapers/Energy/energy-12.jpgis excluded by!**/*.jpgextension-sources/webadderall.more-wallpapers/wallpapers/Energy/energy-13.jpgis excluded by!**/*.jpgextension-sources/webadderall.more-wallpapers/wallpapers/Energy/energy-14.jpgis excluded by!**/*.jpgextension-sources/webadderall.more-wallpapers/wallpapers/Energy/energy-15.jpgis excluded by!**/*.jpgextension-sources/webadderall.more-wallpapers/wallpapers/Energy/energy-16.jpgis excluded by!**/*.jpgextension-sources/webadderall.more-wallpapers/wallpapers/Energy/energy-17.jpgis excluded by!**/*.jpgextension-sources/webadderall.more-wallpapers/wallpapers/Energy/energy-18.jpgis excluded by!**/*.jpgextension-sources/webadderall.more-wallpapers/wallpapers/Energy/energy-19.jpgis excluded by!**/*.jpgextension-sources/webadderall.more-wallpapers/wallpapers/Energy/energy-2.jpgis excluded by!**/*.jpgextension-sources/webadderall.more-wallpapers/wallpapers/Energy/energy-20.jpgis excluded by!**/*.jpgextension-sources/webadderall.more-wallpapers/wallpapers/Energy/energy-21.jpgis excluded by!**/*.jpgextension-sources/webadderall.more-wallpapers/wallpapers/Energy/energy-22.jpgis excluded by!**/*.jpgextension-sources/webadderall.more-wallpapers/wallpapers/Energy/energy-23.jpgis excluded by!**/*.jpgextension-sources/webadderall.more-wallpapers/wallpapers/Energy/energy-3.jpgis excluded by!**/*.jpgextension-sources/webadderall.more-wallpapers/wallpapers/Energy/energy-4.jpgis excluded by!**/*.jpgextension-sources/webadderall.more-wallpapers/wallpapers/Energy/energy-5.jpgis excluded by!**/*.jpgextension-sources/webadderall.more-wallpapers/wallpapers/Energy/energy-6.jpgis excluded by!**/*.jpgextension-sources/webadderall.more-wallpapers/wallpapers/Energy/energy-7.jpgis excluded by!**/*.jpgextension-sources/webadderall.more-wallpapers/wallpapers/Energy/energy-8.jpgis excluded by!**/*.jpgextension-sources/webadderall.more-wallpapers/wallpapers/Energy/energy-9.jpgis excluded by!**/*.jpgextension-sources/webadderall.more-wallpapers/wallpapers/Glassmorphism/glassmorphism-1.jpgis excluded by!**/*.jpgextension-sources/webadderall.more-wallpapers/wallpapers/Glassmorphism/glassmorphism-10.jpgis excluded by!**/*.jpgextension-sources/webadderall.more-wallpapers/wallpapers/Glassmorphism/glassmorphism-2.jpgis excluded by!**/*.jpgextension-sources/webadderall.more-wallpapers/wallpapers/Glassmorphism/glassmorphism-3.jpgis excluded by!**/*.jpgextension-sources/webadderall.more-wallpapers/wallpapers/Glassmorphism/glassmorphism-4.jpgis excluded by!**/*.jpgextension-sources/webadderall.more-wallpapers/wallpapers/Glassmorphism/glassmorphism-5.jpgis excluded by!**/*.jpgextension-sources/webadderall.more-wallpapers/wallpapers/Glassmorphism/glassmorphism-6.jpgis excluded by!**/*.jpgextension-sources/webadderall.more-wallpapers/wallpapers/Glassmorphism/glassmorphism-7.jpgis excluded by!**/*.jpgextension-sources/webadderall.more-wallpapers/wallpapers/Glassmorphism/glassmorphism-8.jpgis excluded by!**/*.jpgextension-sources/webadderall.more-wallpapers/wallpapers/Glassmorphism/glassmorphism-9.jpgis excluded by!**/*.jpgextension-sources/webadderall.more-wallpapers/wallpapers/Iridescent/iridescent-1.jpgis excluded by!**/*.jpgextension-sources/webadderall.more-wallpapers/wallpapers/Iridescent/iridescent-10.jpgis excluded by!**/*.jpgextension-sources/webadderall.more-wallpapers/wallpapers/Iridescent/iridescent-11.jpgis excluded by!**/*.jpgextension-sources/webadderall.more-wallpapers/wallpapers/Iridescent/iridescent-12.jpgis excluded by!**/*.jpgextension-sources/webadderall.more-wallpapers/wallpapers/Iridescent/iridescent-13.jpgis excluded by!**/*.jpgextension-sources/webadderall.more-wallpapers/wallpapers/Iridescent/iridescent-14.jpgis excluded by!**/*.jpgextension-sources/webadderall.more-wallpapers/wallpapers/Iridescent/iridescent-15.jpgis excluded by!**/*.jpgextension-sources/webadderall.more-wallpapers/wallpapers/Iridescent/iridescent-16.jpgis excluded by!**/*.jpgextension-sources/webadderall.more-wallpapers/wallpapers/Iridescent/iridescent-17.jpgis excluded by!**/*.jpgextension-sources/webadderall.more-wallpapers/wallpapers/Iridescent/iridescent-2.jpgis excluded by!**/*.jpgextension-sources/webadderall.more-wallpapers/wallpapers/Iridescent/iridescent-3.jpgis excluded by!**/*.jpgextension-sources/webadderall.more-wallpapers/wallpapers/Iridescent/iridescent-4.jpgis excluded by!**/*.jpgextension-sources/webadderall.more-wallpapers/wallpapers/Iridescent/iridescent-5.jpgis excluded by!**/*.jpgextension-sources/webadderall.more-wallpapers/wallpapers/Iridescent/iridescent-6.jpgis excluded by!**/*.jpgextension-sources/webadderall.more-wallpapers/wallpapers/Iridescent/iridescent-7.jpgis excluded by!**/*.jpgextension-sources/webadderall.more-wallpapers/wallpapers/Iridescent/iridescent-8.jpgis excluded by!**/*.jpgextension-sources/webadderall.more-wallpapers/wallpapers/Iridescent/iridescent-9.jpgis excluded by!**/*.jpgextension-sources/webadderall.more-wallpapers/wallpapers/Midnight/midnight-1.jpgis excluded by!**/*.jpgextension-sources/webadderall.more-wallpapers/wallpapers/Midnight/midnight-10.jpgis excluded by!**/*.jpgextension-sources/webadderall.more-wallpapers/wallpapers/Midnight/midnight-11.jpgis excluded by!**/*.jpgextension-sources/webadderall.more-wallpapers/wallpapers/Midnight/midnight-12.jpgis excluded by!**/*.jpgextension-sources/webadderall.more-wallpapers/wallpapers/Midnight/midnight-13.jpgis excluded by!**/*.jpgextension-sources/webadderall.more-wallpapers/wallpapers/Midnight/midnight-14.jpgis excluded by!**/*.jpgextension-sources/webadderall.more-wallpapers/wallpapers/Midnight/midnight-15.jpgis excluded by!**/*.jpgextension-sources/webadderall.more-wallpapers/wallpapers/Midnight/midnight-16.jpgis excluded by!**/*.jpgextension-sources/webadderall.more-wallpapers/wallpapers/Midnight/midnight-17.jpgis excluded by!**/*.jpgextension-sources/webadderall.more-wallpapers/wallpapers/Midnight/midnight-18.jpgis excluded by!**/*.jpgextension-sources/webadderall.more-wallpapers/wallpapers/Midnight/midnight-2.jpgis excluded by!**/*.jpgextension-sources/webadderall.more-wallpapers/wallpapers/Midnight/midnight-3.jpgis excluded by!**/*.jpgextension-sources/webadderall.more-wallpapers/wallpapers/Midnight/midnight-4.jpgis excluded by!**/*.jpgextension-sources/webadderall.more-wallpapers/wallpapers/Midnight/midnight-5.jpgis excluded by!**/*.jpgextension-sources/webadderall.more-wallpapers/wallpapers/Midnight/midnight-6.jpgis excluded by!**/*.jpgextension-sources/webadderall.more-wallpapers/wallpapers/Midnight/midnight-7.jpgis excluded by!**/*.jpgextension-sources/webadderall.more-wallpapers/wallpapers/Midnight/midnight-8.jpgis excluded by!**/*.jpgextension-sources/webadderall.more-wallpapers/wallpapers/Midnight/midnight-9.jpgis excluded by!**/*.jpgextension-sources/webadderall.more-wallpapers/wallpapers/Radiant/radiant-1.jpgis excluded by!**/*.jpgextension-sources/webadderall.more-wallpapers/wallpapers/Radiant/radiant-10.jpgis excluded by!**/*.jpgextension-sources/webadderall.more-wallpapers/wallpapers/Radiant/radiant-11.jpgis excluded by!**/*.jpgextension-sources/webadderall.more-wallpapers/wallpapers/Radiant/radiant-12.jpgis excluded by!**/*.jpgextension-sources/webadderall.more-wallpapers/wallpapers/Radiant/radiant-13.jpgis excluded by!**/*.jpgextension-sources/webadderall.more-wallpapers/wallpapers/Radiant/radiant-14.jpgis excluded by!**/*.jpgextension-sources/webadderall.more-wallpapers/wallpapers/Radiant/radiant-15.jpgis excluded by!**/*.jpgextension-sources/webadderall.more-wallpapers/wallpapers/Radiant/radiant-16.jpgis excluded by!**/*.jpgextension-sources/webadderall.more-wallpapers/wallpapers/Radiant/radiant-17.jpgis excluded by!**/*.jpgextension-sources/webadderall.more-wallpapers/wallpapers/Radiant/radiant-18.jpgis excluded by!**/*.jpgextension-sources/webadderall.more-wallpapers/wallpapers/Radiant/radiant-19.jpgis excluded by!**/*.jpgextension-sources/webadderall.more-wallpapers/wallpapers/Radiant/radiant-2.jpgis excluded by!**/*.jpgextension-sources/webadderall.more-wallpapers/wallpapers/Radiant/radiant-20.jpgis excluded by!**/*.jpgextension-sources/webadderall.more-wallpapers/wallpapers/Radiant/radiant-3.jpgis excluded by!**/*.jpgextension-sources/webadderall.more-wallpapers/wallpapers/Radiant/radiant-4.jpgis excluded by!**/*.jpgextension-sources/webadderall.more-wallpapers/wallpapers/Radiant/radiant-5.jpgis excluded by!**/*.jpgextension-sources/webadderall.more-wallpapers/wallpapers/Radiant/radiant-6.jpgis excluded by!**/*.jpgextension-sources/webadderall.more-wallpapers/wallpapers/Radiant/radiant-7.jpgis excluded by!**/*.jpgextension-sources/webadderall.more-wallpapers/wallpapers/Radiant/radiant-8.jpgis excluded by!**/*.jpgextension-sources/webadderall.more-wallpapers/wallpapers/Radiant/radiant-9.jpgis excluded by!**/*.jpgextension-sources/webadderall.more-wallpapers/wallpapers/Raycast/autumnal-peach.jpgis excluded by!**/*.jpgextension-sources/webadderall.more-wallpapers/wallpapers/Raycast/blob-red.jpgis excluded by!**/*.jpgextension-sources/webadderall.more-wallpapers/wallpapers/Raycast/blob.jpgis excluded by!**/*.jpgextension-sources/webadderall.more-wallpapers/wallpapers/Raycast/blossom.jpgis excluded by!**/*.jpgextension-sources/webadderall.more-wallpapers/wallpapers/Raycast/blue-distortion-1.jpgis excluded by!**/*.jpgextension-sources/webadderall.more-wallpapers/wallpapers/Raycast/blue-distortion-2.jpgis excluded by!**/*.jpgextension-sources/webadderall.more-wallpapers/wallpapers/Raycast/blushing-fire.jpgis excluded by!**/*.jpgextension-sources/webadderall.more-wallpapers/wallpapers/Raycast/bright-rain.jpgis excluded by!**/*.jpgextension-sources/webadderall.more-wallpapers/wallpapers/Raycast/chromatic-dark-1.jpgis excluded by!**/*.jpgextension-sources/webadderall.more-wallpapers/wallpapers/Raycast/chromatic-dark-2.jpgis excluded by!**/*.jpgextension-sources/webadderall.more-wallpapers/wallpapers/Raycast/chromatic-light-1.jpgis excluded by!**/*.jpgextension-sources/webadderall.more-wallpapers/wallpapers/Raycast/chromatic-light-2.jpgis excluded by!**/*.jpgextension-sources/webadderall.more-wallpapers/wallpapers/Raycast/cube-mono.jpgis excluded by!**/*.jpgextension-sources/webadderall.more-wallpapers/wallpapers/Raycast/cube-prod.jpgis excluded by!**/*.jpgextension-sources/webadderall.more-wallpapers/wallpapers/Raycast/floss.jpgis excluded by!**/*.jpgextension-sources/webadderall.more-wallpapers/wallpapers/Raycast/glass-rainbow.jpgis excluded by!**/*.jpgextension-sources/webadderall.more-wallpapers/wallpapers/Raycast/good-vibes.jpgis excluded by!**/*.jpgextension-sources/webadderall.more-wallpapers/wallpapers/Raycast/loupe-mono-dark.jpgis excluded by!**/*.jpgextension-sources/webadderall.more-wallpapers/wallpapers/Raycast/loupe-mono-light.jpgis excluded by!**/*.jpgextension-sources/webadderall.more-wallpapers/wallpapers/Raycast/loupe.jpgis excluded by!**/*.jpgextension-sources/webadderall.more-wallpapers/wallpapers/Raycast/mono-dark-distortion-1.jpgis excluded by!**/*.jpgextension-sources/webadderall.more-wallpapers/wallpapers/Raycast/mono-dark-distortion-2.jpgis excluded by!**/*.jpgextension-sources/webadderall.more-wallpapers/wallpapers/Raycast/mono-light-distortion-1.jpgis excluded by!**/*.jpgextension-sources/webadderall.more-wallpapers/wallpapers/Raycast/mono-light-distortion-2.jpgis excluded by!**/*.jpgextension-sources/webadderall.more-wallpapers/wallpapers/Raycast/moonrise.jpgis excluded by!**/*.jpgextension-sources/webadderall.more-wallpapers/wallpapers/Raycast/ray-of-lights.jpgis excluded by!**/*.jpgextension-sources/webadderall.more-wallpapers/wallpapers/Raycast/red-distortion-1.jpgis excluded by!**/*.jpgextension-sources/webadderall.more-wallpapers/wallpapers/Raycast/red-distortion-2.jpgis excluded by!**/*.jpgextension-sources/webadderall.more-wallpapers/wallpapers/Raycast/red-distortion-3.jpgis excluded by!**/*.jpgextension-sources/webadderall.more-wallpapers/wallpapers/Raycast/red-distortion-4.jpgis excluded by!**/*.jpgextension-sources/webadderall.more-wallpapers/wallpapers/Raycast/rose-thorn.jpgis excluded by!**/*.jpgextension-sources/webadderall.more-wallpapers/wallpapers/Spring/spring-1.jpgis excluded by!**/*.jpgextension-sources/webadderall.more-wallpapers/wallpapers/Spring/spring-10.jpgis excluded by!**/*.jpgextension-sources/webadderall.more-wallpapers/wallpapers/Spring/spring-11.jpgis excluded by!**/*.jpgextension-sources/webadderall.more-wallpapers/wallpapers/Spring/spring-12.jpgis excluded by!**/*.jpgextension-sources/webadderall.more-wallpapers/wallpapers/Spring/spring-13.jpgis excluded by!**/*.jpgextension-sources/webadderall.more-wallpapers/wallpapers/Spring/spring-14.jpgis excluded by!**/*.jpgextension-sources/webadderall.more-wallpapers/wallpapers/Spring/spring-15.jpgis excluded by!**/*.jpgextension-sources/webadderall.more-wallpapers/wallpapers/Spring/spring-16.jpgis excluded by!**/*.jpgextension-sources/webadderall.more-wallpapers/wallpapers/Spring/spring-17.jpgis excluded by!**/*.jpgextension-sources/webadderall.more-wallpapers/wallpapers/Spring/spring-18.jpgis excluded by!**/*.jpgextension-sources/webadderall.more-wallpapers/wallpapers/Spring/spring-19.jpgis excluded by!**/*.jpgextension-sources/webadderall.more-wallpapers/wallpapers/Spring/spring-2.jpgis excluded by!**/*.jpgextension-sources/webadderall.more-wallpapers/wallpapers/Spring/spring-20.jpgis excluded by!**/*.jpgextension-sources/webadderall.more-wallpapers/wallpapers/Spring/spring-21.jpgis excluded by!**/*.jpgextension-sources/webadderall.more-wallpapers/wallpapers/Spring/spring-22.jpgis excluded by!**/*.jpgextension-sources/webadderall.more-wallpapers/wallpapers/Spring/spring-23.jpgis excluded by!**/*.jpgextension-sources/webadderall.more-wallpapers/wallpapers/Spring/spring-24.jpgis excluded by!**/*.jpgextension-sources/webadderall.more-wallpapers/wallpapers/Spring/spring-3.jpgis excluded by!**/*.jpgextension-sources/webadderall.more-wallpapers/wallpapers/Spring/spring-4.jpgis excluded by!**/*.jpgextension-sources/webadderall.more-wallpapers/wallpapers/Spring/spring-5.jpgis excluded by!**/*.jpgextension-sources/webadderall.more-wallpapers/wallpapers/Spring/spring-6.jpgis excluded by!**/*.jpgextension-sources/webadderall.more-wallpapers/wallpapers/Spring/spring-7.jpgis excluded by!**/*.jpgextension-sources/webadderall.more-wallpapers/wallpapers/Spring/spring-8.jpgis excluded by!**/*.jpgextension-sources/webadderall.more-wallpapers/wallpapers/Spring/spring-9.jpgis excluded by!**/*.jpgextension-sources/webadderall.more-wallpapers/wallpapers/Sunset/sunset-1.jpgis excluded by!**/*.jpgextension-sources/webadderall.more-wallpapers/wallpapers/Sunset/sunset-10.jpgis excluded by!**/*.jpgextension-sources/webadderall.more-wallpapers/wallpapers/Sunset/sunset-11.jpgis excluded by!**/*.jpgextension-sources/webadderall.more-wallpapers/wallpapers/Sunset/sunset-12.jpgis excluded by!**/*.jpgextension-sources/webadderall.more-wallpapers/wallpapers/Sunset/sunset-13.jpgis excluded by!**/*.jpgextension-sources/webadderall.more-wallpapers/wallpapers/Sunset/sunset-14.jpgis excluded by!**/*.jpgextension-sources/webadderall.more-wallpapers/wallpapers/Sunset/sunset-15.jpgis excluded by!**/*.jpgextension-sources/webadderall.more-wallpapers/wallpapers/Sunset/sunset-16.jpgis excluded by!**/*.jpgextension-sources/webadderall.more-wallpapers/wallpapers/Sunset/sunset-17.jpgis excluded by!**/*.jpgextension-sources/webadderall.more-wallpapers/wallpapers/Sunset/sunset-18.jpgis excluded by!**/*.jpgextension-sources/webadderall.more-wallpapers/wallpapers/Sunset/sunset-19.jpgis excluded by!**/*.jpgextension-sources/webadderall.more-wallpapers/wallpapers/Sunset/sunset-2.jpgis excluded by!**/*.jpgextension-sources/webadderall.more-wallpapers/wallpapers/Sunset/sunset-20.jpgis excluded by!**/*.jpgextension-sources/webadderall.more-wallpapers/wallpapers/Sunset/sunset-21.jpgis excluded by!**/*.jpgextension-sources/webadderall.more-wallpapers/wallpapers/Sunset/sunset-3.jpgis excluded by!**/*.jpgextension-sources/webadderall.more-wallpapers/wallpapers/Sunset/sunset-4.jpgis excluded by!**/*.jpgextension-sources/webadderall.more-wallpapers/wallpapers/Sunset/sunset-5.jpgis excluded by!**/*.jpgextension-sources/webadderall.more-wallpapers/wallpapers/Sunset/sunset-6.jpgis excluded by!**/*.jpgextension-sources/webadderall.more-wallpapers/wallpapers/Sunset/sunset-7.jpgis excluded by!**/*.jpgextension-sources/webadderall.more-wallpapers/wallpapers/Sunset/sunset-8.jpgis excluded by!**/*.jpgextension-sources/webadderall.more-wallpapers/wallpapers/Sunset/sunset-9.jpgis excluded by!**/*.jpgextension-sources/webadderall.more-wallpapers/wallpapers/macOS/ipad-17-dark.jpgis excluded by!**/*.jpgextension-sources/webadderall.more-wallpapers/wallpapers/macOS/ipad-17-light.jpgis excluded by!**/*.jpgextension-sources/webadderall.more-wallpapers/wallpapers/macOS/sequoia-blue-orange.jpgis excluded by!**/*.jpgextension-sources/webadderall.more-wallpapers/wallpapers/macOS/sequoia-blue.jpgis excluded by!**/*.jpgextension-sources/webadderall.more-wallpapers/wallpapers/macOS/sonoma-clouds.jpgis excluded by!**/*.jpgextension-sources/webadderall.more-wallpapers/wallpapers/macOS/sonoma-dark.jpgis excluded by!**/*.jpgextension-sources/webadderall.more-wallpapers/wallpapers/macOS/sonoma-evening.jpgis excluded by!**/*.jpgextension-sources/webadderall.more-wallpapers/wallpapers/macOS/sonoma-from-above.jpgis excluded by!**/*.jpgextension-sources/webadderall.more-wallpapers/wallpapers/macOS/sonoma-horizon.jpgis excluded by!**/*.jpgextension-sources/webadderall.more-wallpapers/wallpapers/macOS/sonoma-light.jpgis excluded by!**/*.jpgextension-sources/webadderall.more-wallpapers/wallpapers/macOS/sonoma-river.jpgis excluded by!**/*.jpgextension-sources/webadderall.more-wallpapers/wallpapers/macOS/tahoe-dark.jpgis excluded by!**/*.jpgextension-sources/webadderall.more-wallpapers/wallpapers/macOS/tahoe-light.jpgis excluded by!**/*.jpgextension-sources/webadderall.more-wallpapers/wallpapers/macOS/ventura-dark.jpgis excluded by!**/*.jpgextension-sources/webadderall.more-wallpapers/wallpapers/macOS/ventura-semi-dark.jpgis excluded by!**/*.jpgextension-sources/webadderall.more-wallpapers/wallpapers/macOS/ventura.jpgis excluded by!**/*.jpg
📒 Files selected for processing (8)
.gitignoreextension-sources/insomniachooman.cool-cursors/index.jsextension-sources/insomniachooman.cool-cursors/recordly-extension.jsonextension-sources/webadderall.more-wallpapers/index.jsextension-sources/webadderall.more-wallpapers/recordly-extension.jsonsrc/components/video-editor/ExtensionManager.tsxsrc/components/video-editor/TutorialHelp.tsxsrc/components/video-editor/timeline/TimelineEditor.tsx
💤 Files with no reviewable changes (4)
- extension-sources/insomniachooman.cool-cursors/index.js
- extension-sources/insomniachooman.cool-cursors/recordly-extension.json
- extension-sources/webadderall.more-wallpapers/index.js
- extension-sources/webadderall.more-wallpapers/recordly-extension.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes 91MB of bundled extension source assets from the repo and replaces all
lucide-reactimports with@phosphor-icons/react(which the project already uses everywhere else).Changes
Remove extension-sources/ (91MB)
extension-sources/directory containing bundled wallpaper/cursor extension assetsextension-sources/to.gitignoreReplace lucide-react with phosphor icons
This fixes the missing
lucide-reactdependency (it was never in package.json) and theTwitterexport crash reported in #261.Linux window issue
The Linux tray-only / no-window issue from #261 is a separate GPU/Wayland problem — the HUD window uses
did-finish-loadto show, which may never fire if the renderer fails due to VAAPI errors. That needs a separate fix (GPU fallback flags + ready-to-show handler for Linux).Closes #261 (lucide-react portion)
Summary by CodeRabbit