Skip to content

fix(linux): allow full-screen capture by position if IDs do not match #267

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
webadderall merged 1 commit into from
Apr 18, 2026
Merged

fix(linux): allow full-screen capture by position if IDs do not match #267

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion electron/ipc/register/sources.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,10 +101,19 @@ export function registerSourceHandlers({
.filter((source) => source.id.startsWith("screen:"))
.map((source) => [String(source.display_id ?? ""), source] as const),
);
// On Linux, desktopCapturer display_id values may not match screen.getAllDisplays() IDs.
// Keep an ordered list so we can fall back to position-based matching.
const electronScreenSourcesByIndex = electronSources.filter((source) =>
source.id.startsWith("screen:"),
);

const screenSources = displays.map((display, index) => {
const displayId = String(display.id);
const matchedSource = electronScreenSourcesByDisplayId.get(displayId);
const matchedSource =
electronScreenSourcesByDisplayId.get(displayId) ??
(electronScreenSourcesByIndex.length === displays.length
? electronScreenSourcesByIndex[index]
: undefined);
const displayName =
displayId === primaryDisplayId
? `Screen ${index + 1} (Primary)`
Expand Down