Added full support for the French language.#291
Conversation
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (5)
✅ Files skipped from review due to trivial changes (5)
📝 WalkthroughWalkthroughAdd French localization: include Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@src/i18n/config.ts`:
- Line 3: SUPPORTED_LOCALES was extended to include "fr" which widened the
AppLocale union, but APP_LANGUAGE_LABELS in SettingsPanel.tsx is missing the
"fr" key and now causes a TypeScript exhaustiveness error; update the
APP_LANGUAGE_LABELS Record<AppLocale, string> (in
src/components/video-editor/SettingsPanel.tsx) to include an entry for "fr"
(e.g., the French label) so the record is exhaustive and matches the
SUPPORTED_LOCALES/AppLocale union.
In `@src/i18n/locales/fr/launch.json`:
- Around line 1-77: The French locale file contains English strings — replace
every English value under the top-level keys "recording", "sourceSelector",
"permissions" and the nested "update" object with proper French translations,
preserving interpolation placeholders like {{path}}, {{name}}, {{version}}, and
{{error}} exactly as-is; update keys such as "record", "stop", "cancel",
"loadingSources", "screenRecordingNeeded", and all "update.*" titles to French
equivalents so the UI shows French text for the recording controls, source
selector and permission prompts.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: df4992c5-3765-4c85-8979-d7ffdcae5654
📒 Files selected for processing (10)
src/contexts/I18nContext.tsxsrc/i18n/config.tssrc/i18n/locales/fr/common.jsonsrc/i18n/locales/fr/dialogs.jsonsrc/i18n/locales/fr/editor.jsonsrc/i18n/locales/fr/extensions.jsonsrc/i18n/locales/fr/launch.jsonsrc/i18n/locales/fr/settings.jsonsrc/i18n/locales/fr/shortcuts.jsonsrc/i18n/locales/fr/timeline.json
|
please resolve coderabbit review issues |
|
Okay, I've applied the fixes. |
|
Closing this PR to opening it from a dedicated branch |
2 participants
Pull Request Template
Description
Added full support for the French language.
Motivation
To allow French-speaking users to use Recordly in their native language.
Type of Change
Related Issue(s)
N/A
Screenshots
Testing Guide
Checklist
Summary by CodeRabbit