Fix project save flow, preview playback, and clip cleanup#303
Closed
webadderall wants to merge 11 commits intorefactor/split-part1from
Closed
Fix project save flow, preview playback, and clip cleanup#303webadderall wants to merge 11 commits intorefactor/split-part1from
webadderall wants to merge 11 commits intorefactor/split-part1from
Conversation
- AnnotationTextTab: use ?? instead of || so empty text can be cleared - ExtensionManager: add catch block for marketplace install failures - useEditorExport: wrap retry save in try/catch for unhandled rejections - editorExportWorkflow: move playback restore to finally block
- Gate audio level meter to selected mic device only (helperComponents) - Clear webcam deviceId when 'Default' selected (LaunchWindow) - Wire i18n for 'Custom Fonts' and 'Color' labels (AnnotationTextTab) - Restore keyboard focus ring on sidebar buttons (EditorSidebar) - Add visually-hidden DialogTitle for a11y (ExtensionDetailModal) - Make extension cards keyboard-accessible with role/tabIndex (ExtensionManagerCards) - Write smoke export reports for GIF exports before closing (editorExportWorkflow) - Guard GIF export against zero video dimensions (useEditorExport) - Allow 'Save Again' before requiring loaded video (useEditorExport)
UI decision — removes default focus ring to avoid ugly yellow selection ring.
…ix Windows paths, translate i18n - Export dropdown now stays open on GIF/MP4 failure and top-level catch so the exportError UI remains visible (previously dismissed by finally block) - handleCancelExport always resets UI state even before exporter is constructed, so Cancel works during the async setup phase - fromFileUrl() now converts forward slashes to backslashes for Windows drive paths (both primary and fallback parsing paths) - Translated customFonts and color keys in es/ko/nl/zh-CN locales
GIF save-failure and MP4 save-failure paths had the same bug as the export-failure paths: dropdown closes hiding the exportError UI. Now keepExportDialogOpen = true in all non-smoke failure branches.
… localize account button - RecordingControls now accepts and wires toggleMicrophone so the mic button actually works during recording - gifOutputDimensions and desiredMp4SourceDimensions now use a reactive videoDimensions state (set on loadedmetadata) instead of reading from a ref in useMemo, fixing stale 1920x1080 fallback on first render - Account button text now goes through i18n with translations for all 5 locales
The toggleMicrophone and resumeRecording props were on the same line as microphoneEnabled, causing the recording HUD buttons to break.
Contributor
|
Caution Review failedPull request was closed or merged during review 📝 WalkthroughWalkthroughThis PR undertakes a comprehensive refactoring of the LaunchWindow component (decomposing 1,647 lines into modular sub-files), reorganizes AnnotationSettingsPanel into focused tab components, and significantly restructures the video editor's component and hook architecture with new editor UI components and twelve specialized hooks for managing regions, captions, preferences, export, and state persistence. Changes
Estimated code review effort🎯 5 (Critical) | ⏱️ ~120+ minutes Possibly related PRs
Suggested labels
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Summary by CodeRabbit
New Features
Refactoring