-
-
Notifications
You must be signed in to change notification settings - Fork 749
Fix embedded audio fallback handling and audio diagnostics #309
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
webadderall
wants to merge
3
commits into
main
Choose a base branch
from
fix/embedded-audio-sidecar-diagnostics
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,23 @@ | ||
| import { describe, expect, it } from "vitest"; | ||
|
|
||
| import { shouldUseWindowsBrowserMicrophoneFallback } from "./windowsFallbacks"; | ||
|
|
||
| describe("shouldUseWindowsBrowserMicrophoneFallback", () => { | ||
| it("returns true when native Windows mic initialization fails", () => { | ||
| expect( | ||
| shouldUseWindowsBrowserMicrophoneFallback( | ||
| "WARNING: Failed to initialize WASAPI mic capture\nRecording started", | ||
| { capturesMicrophone: true }, | ||
| ), | ||
| ).toBe(true); | ||
| }); | ||
|
|
||
| it("returns false when microphone capture was not requested", () => { | ||
| expect( | ||
| shouldUseWindowsBrowserMicrophoneFallback( | ||
| "WARNING: Failed to initialize WASAPI mic capture\nRecording started", | ||
| { capturesMicrophone: false }, | ||
| ), | ||
| ).toBe(false); | ||
| }); | ||
| }); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,11 @@ | ||
| const WINDOWS_MIC_CAPTURE_INIT_WARNING = "WARNING: Failed to initialize WASAPI mic capture"; | ||
|
|
||
| export function shouldUseWindowsBrowserMicrophoneFallback( | ||
| captureOutput: string, | ||
| options?: { capturesMicrophone?: boolean }, | ||
| ) { | ||
| return ( | ||
| Boolean(options?.capturesMicrophone) && | ||
| captureOutput.includes(WINDOWS_MIC_CAPTURE_INIT_WARNING) | ||
| ); | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fallback may leave an orphan
.mic.wavon disk.Line 213 hands
config.micOutputPath = microphonePathto the spawned native helper before it attempts WASAPI init. If the helper creates (or truncates) the file handle prior to failing init — even to 0 bytes — the fallback path on 278-281 only nulls the in-memory state and doesn't unlink the file. Downstream mux / sidecar discovery code that scans the recordings directory by filename pattern could then pick up an empty.mic.wavalongside the real browser-captured sidecar.Consider best-effort removal of the file when fallback is required, and/or only persisting
setWindowsMicAudioPathafter a successful start.🧹 Proposed cleanup on fallback
if (microphoneFallbackRequired) { + const orphanMicPath = microphonePath microphonePath = null setWindowsMicAudioPath(null) + if (orphanMicPath) { + void fs.unlink(orphanMicPath).catch(() => { /* best-effort */ }) + } }Also applies to: 274-281
🤖 Prompt for AI Agents