fix(launch): disable floating webcam preview without passthrough#321
Open
meiiie wants to merge 1 commit intowebadderallorg:mainfrom
Open
fix(launch): disable floating webcam preview without passthrough#321meiiie wants to merge 1 commit intowebadderallorg:mainfrom
meiiie wants to merge 1 commit intowebadderallorg:mainfrom
Conversation
Contributor
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Disable the floating webcam preview when the HUD overlay cannot support mouse passthrough.
Motivation
Issue #320 reports that enabling the floating webcam preview on Windows 10 makes the desktop unusable outside the HUD. The problem is that the recording HUD expands to the full viewport for the draggable preview, but Windows 10 currently falls back to a non-passthrough overlay window.
Root Cause
When
showRecordingWebcamPreviewis enabled, the renderer reports a full-viewport HUD size so the floating preview can be dragged anywhere on screen. On platforms whereisHudOverlayMousePassthroughSupported()is false, that turns the transparent HUD overlay into a fullscreen click blocker.Changes
Related Issue(s)
Testing Guide
node ./node_modules/vitest/vitest.mjs run src/components/launch/floatingWebcamPreview.test.tsnode ./node_modules/typescript/bin/tsc --noEmitnode ./node_modules/@biomejs/biome/bin/biome check electron/windows.ts electron/preload.ts electron/electron-env.d.ts src/components/launch/LaunchWindow.tsx src/components/launch/floatingWebcamPreview.ts src/components/launch/floatingWebcamPreview.test.tsNotes
This keeps the existing floating preview behavior on platforms where HUD passthrough is supported, while falling back to the non-floating webcam controls on platforms where a fullscreen transparent overlay would block the desktop.