Skip to content

[codex] clean up clip-first timeline editing #406

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
webadderall wants to merge 4 commits into
base: main
Choose a base branch
from
Open

[codex] clean up clip-first timeline editing #406

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c04255d
Stream blob exports through temp files
webadderall Apr 30, 2026
c0a1299
timeline: add hover ghost preview and safer zoom placement
webadderall May 1, 2026
3e871b9
clean up clip-first timeline editing
webadderall May 2, 2026
b79cedb
fix clip timeline review feedback
webadderall May 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
360 changes: 132 additions & 228 deletions src/components/video-editor/VideoEditor.tsx
View file
Open in desktop

Large diffs are not rendered by default.

21 changes: 20 additions & 1 deletion src/components/video-editor/timeline/Row.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,9 +7,24 @@ interface RowProps extends RowDefinition {
hint?: string;
isEmpty?: boolean;
labelColor?: string;
onMouseEnter?: React.MouseEventHandler<HTMLDivElement>;
onMouseMove?: React.MouseEventHandler<HTMLDivElement>;
onMouseLeave?: React.MouseEventHandler<HTMLDivElement>;
onClick?: React.MouseEventHandler<HTMLDivElement>;
}

export default function Row({ id, children, label, hint, isEmpty, labelColor = "#666" }: RowProps) {
export default function Row({
id,
children,
label,
hint,
isEmpty,
labelColor = "#666",
onMouseEnter,
onMouseMove,
onMouseLeave,
onClick,
}: RowProps) {
const { setNodeRef, rowWrapperStyle, rowStyle } = useRow({ id });

return (
Expand All @@ -34,6 +49,10 @@ export default function Row({ id, children, label, hint, isEmpty, labelColor = "
ref={setNodeRef}
className="relative h-full min-h-[26px] overflow-hidden"
style={rowStyle}
onMouseEnter={onMouseEnter}
onMouseMove={onMouseMove}
onMouseLeave={onMouseLeave}
onClick={onClick}
>
{children}
</div>
Expand Down
Loading