test(export): cover odd MP4 dimension normalization#463
Conversation
|
ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughA new test case was added to verify that ChangesExport Dimensions Test Coverage
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Possibly related PRs
Suggested labels
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
Description
Add focused regression coverage for odd MP4 source dimensions in the export dimension helpers.
Motivation
Follow-up to #462 and CodeRabbit's test-coverage note: the helper already normalizes odd dimensions for encoder safety, but the behavior should be locked by a direct test.
Type of Change
Related Issue(s)
Changes Made
calculateMp4SourceDimensionscalculateMp4ExportDimensionskeepssourceandhighoutputs evenScope Note
Test-only follow-up. No export logic changes.
Testing Guide
Checklist
Local checks run:
npm test -- src/components/video-editor/exportDimensions.test.tsnpx biome check src/components/video-editor/exportDimensions.test.tsgit diff --checkSummary by CodeRabbit