Skip to content

fix(editor): redact session paths in debug log#546

Merged
meiiie merged 1 commit into
mainfrom
fix/editor-redact-session-path-logs
May 20, 2026
Merged

fix(editor): redact session paths in debug log#546
meiiie merged 1 commit into
mainfrom
fix/editor-redact-session-path-logs

Conversation

@meiiie
Copy link
Copy Markdown
Collaborator

@meiiie meiiie commented May 20, 2026

Summary

  • Redact recording session file paths from the onRecordingSessionChanged debug log.
  • Keep the useful debug signal as booleans and the existing path match result.

Why

CodeRabbit flagged that logging raw recording/webcam paths can expose user-identifying local filesystem details in app logs.

Verification

  • npx tsc --noEmit --pretty false
  • git diff --check
  • npx biome lint src/components/video-editor/VideoEditor.tsx (passes with the existing clipRegions exhaustive-deps warning)

Summary by CodeRabbit

  • Chores
    • Improved diagnostic logging in video recording sessions to use presence indicators instead of raw path information.

Review Change Stack

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 20, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 359f88fc-354a-4f7f-80cf-4cfade19064b

📥 Commits

Reviewing files that changed from the base of the PR and between c61de0e and 598334e.

📒 Files selected for processing (1)
  • src/components/video-editor/VideoEditor.tsx

📝 Walkthrough

Walkthrough

Console diagnostic payload in the recording session change handler now logs boolean presence flags (hasSession, hasSessionVideoPath, hasVideoSourcePath, hasWebcamPath) and the existing match comparison, replacing raw path field logging.

Changes

Diagnostic Logging Update

Layer / File(s) Summary
Recording session diagnostic payload
src/components/video-editor/VideoEditor.tsx
The onRecordingSessionChanged handler console log replaces raw session?.videoPath and session?.webcamPath with boolean presence indicators (hasSession, hasSessionVideoPath, hasVideoSourcePath, hasWebcamPath) while retaining the match computation for diagnostic clarity.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

🐰 A logger's delight, truth flags shine bright,
No paths exposed, just presence in sight,
Diagnostics clean, the handler improved,
Boolean clarity, the coder's approved! 📊

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and specifically summarizes the main change: redacting session paths from a debug log in the editor component.
Description check ✅ Passed The description covers the key sections: summary of changes, motivation (why the change is needed), and verification steps, though it omits some template fields like Type of Change checkbox and Testing Guide.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/editor-redact-session-path-logs

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 ESLint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

ESLint skipped: no ESLint configuration detected in root package.json. To enable, add eslint to devDependencies.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@meiiie meiiie merged commit 67a83ca into main May 20, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant