fix(export): tighten native audio safety guards#560
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughThis PR adds validation refinements for audio codec handling in MP4 muxing and NVIDIA CUDA exports. Empty audio codecs now correctly return false from copy-into-MP4 checks, forcing transcoding. CUDA validation now distinguishes missing audio duration from non-positive duration in inline-audio exports. Test coverage validates all three changes. ChangesAudio codec handling and CUDA validation refinements
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested labels
Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 ESLint
ESLint skipped: no ESLint configuration detected in root package.json. To enable, add Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary
Why
This is a final small audio-safety slice from #504. Native export should only trust CUDA inline audio when the output audio stream can be validated, and MP4 muxing should not copy unknown sidecar/WAV/PCM-like codecs blindly.
This PR intentionally avoids route planner, CUDA compositor binary, and dev launcher changes.
Verification
Summary by CodeRabbit
Bug Fixes