Combine segment mask with segment specs#12
Closed
soulofmischief wants to merge 1 commit intomasterfrom
Closed
Conversation
|
@soulofmischief is attempting to deploy a commit to the WEBA Team on Vercel. To accomplish this, @soulofmischief needs to request access to the Team. Afterwards, an owner of the Team is required to accept their membership request. If you're already a member of the respective Vercel Team, make sure that your Personal Vercel Account is connected to your GitHub account. |
This was referenced Dec 18, 2022
avaer
reviewed
Dec 18, 2022
| planesJson, | ||
| planesMask, | ||
| portalJson, | ||
| segmentMask: segmentSpecs.mask, |
Contributor
There was a problem hiding this comment.
This seems wrong. It's not outputting the correct mask.
avaer
suggested changes
Dec 18, 2022
Contributor
Author
Ok, I'll review this now that I have a better understanding of the outmeshing process. |
Contributor
Author
|
Putting on hold pending refactor |
Contributor
|
I think in that case this PR is just wrong and created due to misunderstanding. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove duplicated segment mask data for a 4MiB savings