Unexpected behaviour of "Upload a different image" [New UI]

[DPX-designer]

On step 6 (Screenshot), if I upload an image and then click to Upload a different image, the screenshot is deleted and I am taken back up to the very top of the page.

My expectation as a user would be to be presented with another Open file dialogue to select a different image without going through the process of deleting the current image.

[munteanu210]

@mcroud, thanks for your review. You can see a GIF how screenshot deleting and re-uploading works on my machine, below.

This issue is fixed in the updates submitted in this PR. However, I would recommend reviewing this issue again once this last PR with the mobile view is approved, merged, and the staging / dev site is updated.

I am saying this, because it seems to me the staging / dev site wasn't updated with my latest updates. I want to make sure both PRs from above reach the master branch, and only after that, the staging / dev site is updated to contain everything.

[DPX-designer]

@munteanu210 Thanks for the heads up, I will absolutely check it out again.

[DPX-designer]

Hi @munteanu210, just reviewing this on mobile...

It seems to me that clicking "Upload a different image" has the same effect as "Delete this image", clicking both deletes the image.

The desired effect of "Upload a different image" is that it opens up the "Select file" dialogue WITHOUT deleting the image first. If a new image is selected than this will replace the previous image, if the "Select file" dialogue is closed than the previous image remains.
Please let me know if I've done a poor job at describing this 😆

[munteanu210]

@mcroud, I understood what the problem is. Thanks for identifying it. I fixed it in PR #3011.