This repository was archived by the owner on Sep 14, 2021. It is now read-only.
Fix custom properties for #20#23
Closed
tuespetre wants to merge 4 commits intowebcomponents:masterfrom
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This set of changes fixes custom properties for #20.
At first I made some changes to get the existing tests running. Several still fail in IE due to the lack of a template element polyfill. Then I added two new tests related to #20.
To fix the issue I spent some time exploring the call hierarchy and seeing what was going on. I renamed several variables for clarity and consistency (to be sure that what you're actually looking at is supposed to be an element, or a name, or so forth) and by doing that I was able to sort it out.
It took me a little while to catch on that I needed to use Polyserve to manually run the tests so that might be something to consider for the README.