This repository was archived by the owner on Sep 20, 2019. It is now read-only.
Revert "fixed memory leak while importing html elements in IE"#665
Merged
Conversation
Contributor
|
LGTM, failing tests seem to be status quo. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #644.
Unfortunately, this PR is incorrect and must be reverted. ShadowRoot elements do not contain
<head>or<body>elements as was added here. The custom elements polyfill was changed to always observe<head>and<body>on every element it observes, including documents and shadowRoots. This caused any custom elements added to shadowRoots to not be seen by the mutation observer since the observer is observing disconnected, unusedshadowRoot.headandshadowRoot.bodyelements rather than theshadowRootitself.We'll make sure the issue here gets re-opened and will definitely consider other fixes for the core issue.