homework1 #1
Merged
homework1 #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/homeworks/ts1/1_base.ts
Outdated
|
|
||
| export const removeFirstZeros = (value: string): string => value.replace(/^(-)?[0]+(-?\d+.*)$/, '$1$2'); | ||
|
|
||
| export const getBeautifulNumber = (value?: number | null, separator: string = ' ') => |
There was a problem hiding this comment.
Добрый день тут достаточно (value: number separator: string = ' '):string
Мы жестко принимает примитив => приводим к строке и разбиваем как нужно
separator: string = ' ' если мы кладем значение в переменную то тип указывать не нужно так как будет работать утиная типизация
Стоит указать что возвращает ф-ия так при разработке будет меньше ошибок
| const transformRegexp: RegExp = | ||
| /(matrix\(-?\d+(\.\d+)?, -?\d+(\.\d+)?, -?\d+(\.\d+)?, -?\d+(\.\d+)?, )(-?\d+(\.\d+)?), (-?\d+(\.\d+)?)\)/; | ||
|
|
||
| type TransformedRegexp = { |
| // http://www.w3.org/TR/AERT#color-contrast | ||
| Math.round((red * 299 + green * 587 + blue * 114) / 1000); | ||
|
|
||
| type BlackOrWhite = 'black' | 'white'; |
There was a problem hiding this comment.
Отличное решение которое в дальнейшем может сэкономить уйму сил, времени и денег
src/homeworks/ts1/1_base.ts
Outdated
| number: number; | ||
| }; | ||
|
|
||
| export const getNumberedArray = (arr: unknown[]): NumberedArrayItem[] => |
There was a problem hiding this comment.
Хорошее решение, еще можно использовать джинерики
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.