-
Notifications
You must be signed in to change notification settings - Fork 0
Better support node detection #110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e7fde29 to
b075244
Compare
- Updated vertexConns to take a Map VertexTreeType [Vertex] argument. - Modified logic to compute connection counts per vertex type instead of a flat map. - Introduced helper typeForNames to map vertex names to their corresponding types. - Changed VertexConnMap type to Map VertexTreeType (Map Text Int) for type-aware connection tracking.
- Add `max-support-coordinates` option to YAML config and Config.hs - Replace `x-breakpoints` map with structured `x-group-breakpoints` list (breakpoint + vertex-type) - Introduce `defaultMaxSupportCoordinates` and integrate it into TransformationConfig - Simplify `vertexConns` logic: limit top vertices per type and flatten VertexConnMap - Change VertexConnMap type to Map Text (VertexTreeType, Int) - Rewrite `moveSupportVertices` to use new config-driven threshold logic - Split and clarify `sortVertices` / `sortSupportVertices` functions - Improve readability, consistency, and configurability of transformation pipeline
- Replace `passingBreakpoint :: Scientific -> Bool` with `XGroupBreakpoint Operator Scientific` - Introduce `Operator` type (OpLT, OpGT, OpLE, OpGE) and `applyOperator` function - Update FromJSON instance to parse operator and number from YAML - Adjust default breakpoints to match explicit operator logic - Update `determineGroup` in VertexExtraction to use `applyOperator` - Make dump_ast/Main.hs load config using current working directory
e563fe7 to
58ec9d9
Compare
Owner
Author
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement type-aware support vertex connection tracking described in #69
vertexConnsto compute connection counts per VertexTreeType.VertexConnMapto Map VertexTreeType (Map Text Int) for per-type tracking of vertex connections.80% of that tree’s total vertex count.
This improves accuracy by detecting support vertices relative to their structural group instead of across the entire mesh.