fix: shadcn-ui-builder — add Bash tool and replace unresolvable MCP reference#11
Open
xiaolai wants to merge 1 commit intowebdevtodayjason:mainfrom
Open
fix: shadcn-ui-builder — add Bash tool and replace unresolvable MCP reference#11xiaolai wants to merge 1 commit intowebdevtodayjason:mainfrom
xiaolai wants to merge 1 commit intowebdevtodayjason:mainfrom
Conversation
Two bugs in agents/shadcn-ui-builder/agent.md:
1. The agent body instructs the model to run ShadCN installation
commands ("Install the required ShadCN components using the
appropriate installation commands") but Bash was not declared in
the tools list, making shell execution impossible. Added Bash to
the tools frontmatter.
2. The planning phase instructed "ALWAYS use the MCP server" but no
.mcp.json exists in the repository and no MCP tool is declared,
causing silent failure on every planning invocation. Replaced the
MCP instruction with an equivalent using WebFetch (already in the
tools list) against the ShadCN docs URL.
Co-Authored-By: Claude Code <noreply@anthropic.com>
This was referenced Apr 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
agents/shadcn-ui-builder/agent.mdhas two bugs that cause silent failures at runtime:Bug 1 — Missing Bash tool
The agent body at line 32 says: "Install the required ShadCN components using the appropriate installation commands" and "always use the official ShadCN installation process". ShadCN installation (
npx shadcn@latest add <component>) requires a shell. ButBashwas absent from thetools:frontmatter field, making shell execution impossible. The agent would reach the installation step and have no way to proceed.Fix: Added
Bashto thetoolslist.Bug 2 — Unresolvable MCP server reference
Line 20 (Planning Phase) instructed the agent to "ALWAYS use the MCP server during planning to access ShadCN resources". However:
.mcp.jsonconfiguration file exists anywhere in the repositorytoolslistEvery time this agent entered its planning phase, it would silently skip the MCP step because the described resource is simply not configured. This creates a documentation-to-reality gap.
Fix: Replaced the MCP instruction with an equivalent using
WebFetch(already declared in the tools list) pointed at the ShadCN documentation URL. The planning intent is preserved without requiring external infrastructure.