-
Notifications
You must be signed in to change notification settings - Fork 102
Add support for Dual 200S humidifier device #96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Not sure why the validation build was cancelled — let me know if there's any action I can take there. |
|
Friendly ping @webdjoe — anything else I can add here? |
|
Thank you for the PR, do you mind testing? I combined with the 300S class and excluded the night light feature. |
|
Will do!
…On Wed, Nov 17, 2021, 20:26 Joe Trabulsy ***@***.***> wrote:
Thank you for the PR, do you mind testing? I combined with the 300S class
and excluded the night light feature.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#96 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAFEAU627OJGUWAFUACAEYLUMRW5HANCNFSM5HCW35OQ>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
|
|
Looks like there's a small typo: I've pushed a fix to this PR which makes everything work. Thanks, LMK how it looks. |
|
Great, thank you! Uploading pip package now. |
|
Wonderful! |
Fixes #95. The Dual 200S humidifer seems identical to the Classic 300S humidifier, except it has no night-light.
Tested with: