Skip to content

Replace "<", ">" tokens in data type links with HTML safe counterparts. #57

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ShukantPal merged 1 commit into from
Nov 28, 2020
Merged

Replace "<", ">" tokens in data type links with HTML safe counterparts. #57

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion packages/webdoc-template-library/src/template-plugins/LinkerPlugin.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -193,7 +193,9 @@ function LinkerPluginShell() {
return `<a href=${encodeURI(this.queryCache.get(docPath) || "")}>${linkText}</a>`;
}
if (isDataType(docPath)) {
let link = docPath.template;
let link = docPath.template
.replace(/</g, "&lt;")
.replace(/>/g, "&gt;");
Comment on lines +197 to +198
Copy link
Collaborator

@Zekfad Zekfad Nov 28, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you must escape ", ' and & then too.
ref: https://stackoverflow.com/a/40285312/8035872

Copy link
Member Author

@ShukantPal ShukantPal Nov 28, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're right. Oops.


for (let i = 1; i < docPath.length; i++) {
link = link.replace(`%${i}`, this.linkTo(docPath[i], docPath[i], options));
Expand Down