Skip to content

Conversation

@ShukantPal
Copy link
Member

@ShukantPal ShukantPal commented Nov 28, 2020

Also, pass {htmlSafe:false} in default template signatures b/c they are inside <pre /> <code /> tags.

@ShukantPal
Copy link
Member Author

Inline tag parser

@ShukantPal ShukantPal merged commit aa30fc8 into master Nov 28, 2020
@ShukantPal ShukantPal deleted the feature/inline-code-tags branch November 28, 2020 17:59
@Zekfad
Copy link
Collaborator

Zekfad commented Nov 28, 2020

Reconsider, please: https://stackoverflow.com/a/13010144/8035872

@ShukantPal
Copy link
Member Author

Reconsider, please: https://stackoverflow.com/a/13010144/8035872

Sorry, I meant the signatures are inside <code /> tags so &lt; is not rendered as <.

@Zekfad
Copy link
Collaborator

Zekfad commented Nov 28, 2020

I meant the signatures

Oh, sorry, misunderstood.

@Zekfad
Copy link
Collaborator

Zekfad commented Nov 28, 2020

By the way

b/c they are inside <pre /> <code /> tags.

Is not a good reason, cuz you still have to escape any text coming into any html tags. I guess the better reason is because there are can't be html special characters in signatures by default.

Just to clarify the details.

@ShukantPal
Copy link
Member Author

I don't understand what you mean. I just turned off escaping characters in signatures, that's it.

@Zekfad
Copy link
Collaborator

Zekfad commented Nov 28, 2020

Just nevermind everything is fine, i was taking about pr description this time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants