Feature: Generate sitemaps #94
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zekfad
reviewed
Feb 7, 2021
Comment on lines
+43
to
+53
| /* eslint-disable max-len */ | ||
| const xml = | ||
| `<urlset xmlns="http://www.sitemaps.org/schemas/sitemap/0.9" | ||
| xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" | ||
| xsi:schemaLocation="http://www.sitemaps.org/schemas/sitemap/0.9 http://www.sitemaps.org/schemas/sitemap/0.9/sitemap.xsd"> | ||
| ${this.urls.map((url) => | ||
| ` <url> | ||
| <loc>${this.domain + path.join(this.root, path.relative(this.dir, url))}</loc> | ||
| </url>`).join("\n")} | ||
| </urlset>`; | ||
| /* eslint-enable max-len */ |
Collaborator
There was a problem hiding this comment.
Wouldn't it be better to make another template file instead of hardcoding generation?
Member
Author
There was a problem hiding this comment.
I'm not sure what you mean by hardcoding generation. The template package can still exclude sitemap generation by simply not adding this pipeline element.
Using a pipeline element instead of a template means you don't have to worry about collecting the URLs that were generated. (Documents are the only generated URL - tutorial, class index, package READMEs are all generated)
Collaborator
There was a problem hiding this comment.
I meant this exact part of code could be stored in separated file instead of defining it right in the code. (So you could change XML template with ease.)
Member
Author
|
Yeah, but then you can't use a pipeline element. The pipeline elements are what transform the generated HTML files. I don’t see a lot of value in it right now, especially since very few hands are working the project right now :). This is just a quick n dirty way to generate a sitemap and index the whole website using Algolia.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.