Skip to content

translation(HTML): web/html/element/input/week#1740

Merged
undead404 merged 2 commits intomasterfrom
translation/web-html-element-input-week
Sep 27, 2023
Merged

translation(HTML): web/html/element/input/week#1740
undead404 merged 2 commits intomasterfrom
translation/web-html-element-input-week

Conversation

@undead404
Copy link
Contributor

@undead404 undead404 commented May 11, 2023

@undead404
Copy link
Contributor Author

Оновлення – нікчемне

Copy link
Member

@KlashReik KlashReik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Декілька зауважень

fallbackPicker.style.display = "block";
fallbackLabel.style.display = "block";

// динамічно заповнити тижні
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Не розумію чому тут вже перша буква маленька

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Я, як правило, залишаю регістр як в оригіналі в таких випадках

}

function populateWeeks() {
// заповнити select тижнів 52 тижнями
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

І тут. Так і залишаємо?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Я б залишив

Co-authored-by: KlashReik <107769156+KlashReik@users.noreply.github.com>
@undead404 undead404 merged commit b7ce3dd into master Sep 27, 2023
@undead404 undead404 deleted the translation/web-html-element-input-week branch September 29, 2023 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments