feat(dioxus): multi-window + deeplink (Phase 4-5)

[goosewobbler]

Summary

PR3 first slice — ships Phase 4 (multi-window) and Phase 5 (deeplink) of the Dioxus service rollout. Stacks on feat/dioxus-service.

Phase 4 — Multi-window

Bridge (packages/dioxus-bridge/)

• window_state.rs — process-global registry that auto-labels Dioxus windows in creation order: first is main, rest are window-1, window-2, .... Stores Weak<Window> so closed windows are filtered at query time. Labels are never reused.
• install() chains Config::with_on_window to feed each new window into the registry and registers three invoke commands: __list_windows, __active_window, __window_states.
• Doc note: install() must be the last builder before launch (Dioxus's Config.on_window is an Option<Box<_>> with no getter — a later user with_on_window would silently shadow the bridge hook).

Service (packages/dioxus-service/)

• window.ts — per-sessionId label cache + getDefaultWindowLabel / getCurrentWindowLabel / setCurrentWindowLabel / clearWindowState / getActiveWindowLabel / listWindowLabels / switchWindowByLabel. The switch path validates against the bridge's live list, resolves label → WebDriver handle by walking getWindowHandles(), and restores the original handle on failure.
• service.before() installs switchWindow + listWindows on browser.dioxus.
• service.after() clears the window cache alongside mockStore.

Phase 5 — Deeplink

Service

• commands/triggerDeeplink.ts — validate URL via @wdio/native-core, spawn the platform-native protocol handler:
  • Windows: rundll32.exe url.dll,FileProtocolHandler <url>
  • macOS: open <url>
  • Linux: gio open <url>
• Rejects http:// / https:// / file://.

Bridge

• deeplink.rs — optional reference helper register_handler(scheme, callback) that wraps Config::with_custom_protocol(scheme, ...). Pure convenience for app authors; not required for testing.

Types

• DioxusServiceAPI restored: switchWindow, listWindows, triggerDeeplink.

Test plan

• Bridge: cargo test — 18/18 (3 new in window_state)
• Service: pnpm test:unit — 93/93 (8 new for triggerDeeplink, 14 new for window.ts)
• Typecheck: pnpm typecheck green
• CI green on feat/dioxus-feature-complete

Deferred

• E2E pipeline — fixtures/e2e-apps/dioxus/ doesn't exist yet; PR2 shipped without it. Window + deeplink E2E specs land in a dedicated PR that bootstraps the fixture app.
• Phase 6 (embedded WebDriver provider + browser mode) — separate follow-up PR. Includes new wdio-dioxus-embedded-driver crate + platform executors + providers/embedded.ts + Vite dev-server branch.
• Phase 7 (macOS support + visual regression) — depends on Phase 6.

🤖 Generated with Claude Code

[greptile-apps]

Greptile Summary

This PR ships Phase 4 (multi-window label registry + switchWindow/listWindows service APIs) and Phase 5 (OS-native deeplink dispatch via triggerDeeplink) of the Dioxus service rollout, stacking cleanly on feat/dioxus-service. All three issues surfaced in the prior review pass — dead Weak<Window> accumulation in the registry Vec, the redundant switchToWindow call in switchWindowByLabel, and missing item-type validation in listWindowLabels — have been addressed in this revision.

• Bridge (window_state.rs): monotonic counter drives label allocation so labels are never recycled; register_window now prunes dead entries before pushing new ones, keeping the backing Vec proportional to live windows; get_active_label / list_labels / get_window_states filter at query time via Weak::upgrade.
• Service (window.ts): resolveLabelToHandle leaves the driver focused on the matching handle and returns immediately, eliminating the extra switchToWindow round-trip; listWindowLabels validates item types before casting to string[]; the failure path restores the original handle and re-throws the inner error unmodified to avoid the double-prefix message.
• Service (triggerDeeplink.ts): thin wrapper around @wdio/native-core's validated URL + platform command helpers; 8 new unit tests cover all three OS paths, protocol rejection, and spawn failure propagation.

Confidence Score: 5/5

Safe to merge — the three issues from the prior review are all addressed, the new Rust registry is correctly bounded, and the TS window/deeplink helpers are well-covered by unit tests.

No functional defects found across the new Rust registry, the TS multi-window helpers, or the deeplink command. The label-to-handle resolution approach (OS focus after switchToWindow) is inherently correct for the msedgedriver external-provider path. The monotonic counter correctly decouples label allocation from the pruned entry count. Tests cover the failure and restore paths in sufficient depth.

No files require special attention.

Important Files Changed

Filename	Overview
packages/dioxus-bridge/src/window_state.rs	New process-global window registry with monotonic label counter, Weak liveness tracking, and GC pruning on each new registration; well-tested with 3 unit tests.
packages/dioxus-bridge/src/deeplink.rs	New optional convenience helper that wraps Config::with_custom_protocol for in-app deeplink handling; cleanly documented, pure library code not required for testing.
packages/dioxus-bridge/src/lib.rs	Adds window registry commands (__list_windows, __active_window, __window_states) and with_on_window hook; doc updated to reflect all shipped modules; stale forward-reference removed.
packages/dioxus-service/src/window.ts	New multi-window helpers: per-session label cache, listWindowLabels with item-type validation, and switchWindowByLabel with handle resolution and original-handle restore on failure.
packages/dioxus-service/src/commands/triggerDeeplink.ts	New Phase 5 command that validates the URL via @wdio/native-core, then delegates OS-native protocol dispatch to the same package; thin and well-tested.
packages/dioxus-service/src/service.ts	Wires switchWindow, listWindows, and triggerDeeplink onto browser.dioxus in before(); clears window label cache alongside mockStore in after().
packages/native-types/src/dioxus.ts	DioxusServiceAPI interface updated with switchWindow, listWindows, and triggerDeeplink; stale comment replaced.
packages/dioxus-service/test/window.spec.ts	14 new tests covering label cache, item-type validation, handle resolution, restore-on-failure, and session isolation; comprehensive coverage.
packages/dioxus-service/test/commands/triggerDeeplink.spec.ts	8 new tests covering all three platform commands, URL protocol rejection, malformed URLs, and spawn failure propagation.
packages/dioxus-service/test/service.spec.ts	Extends existing service smoke test to assert switchWindow, listWindows, and triggerDeeplink are installed on browser.dioxus.

Sequence Diagram

sequenceDiagram
    participant Test as Test Script
    participant Svc as DioxusWorkerService
    participant Win as window.ts
    participant WD as WebDriver
    participant Bridge as wdio-dioxus-bridge

    Note over Test,Bridge: switchWindowByLabel('window-1')
    Test->>Svc: browser.dioxus.switchWindow('window-1')
    Svc->>Win: switchWindowByLabel(browser, 'window-1')
    Win->>WD: execute(__list_windows)
    WD->>Bridge: invoke('__list_windows')
    Bridge-->>WD: ['main','window-1']
    WD-->>Win: ['main','window-1']
    Win->>WD: getWindowHandle() → h-main (original)
    loop for each handle
        Win->>WD: switchToWindow(handle)
        Win->>WD: execute(__active_window)
        WD->>Bridge: invoke('__active_window')
        Bridge-->>WD: label
        WD-->>Win: label
        alt "label === targetLabel"
            Win-->>Win: return handle (driver already focused)
        end
    end
    Win->>Win: setCurrentWindowLabel(browser, 'window-1')
    Win-->>Test: void

    Note over Test,Bridge: triggerDeeplink('myapp://open')
    Test->>Svc: browser.dioxus.triggerDeeplink('myapp://open')
    Svc->>Svc: validateDeeplinkUrl('myapp://open')
    Svc->>Svc: getPlatformCommand(url, process.platform)
    Svc->>Svc: executeDeeplinkCommand(cmd, args)
    Note right of Svc: OS routes URL to registered protocol handler
    Svc-->>Test: void

Loading

_{Reviews (2): Last reviewed commit: "fix(dioxus): address greptile P2s on PR ..." | Re-trigger Greptile}