Fix test typings issue with webdriverio #1119
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 tasks
Author
|
Strange that the same tests passed on my fork but not here. Same last commit though. sriteja777#1 @christian-bromann possible to rerun the tests? |
Author
|
Tests passed now for linux 14 ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the
test:typingsencountered in webdriverio v7 tests due to the upgrade to typescript 5@christian-bromann Have changed the types similar to what is there in the expect of jest. Are these valid changes?, this solved the issue with typescript 5 though. I wasn't able to test the functionality, as I am new to this repo and not aware of what type of tests are effected by this. The build and tests passed fine though.
Do you feel testing is necessary for this? In that case, can you guide me on what type of expect assertions need to be tested as part of this PR