-
-
Notifications
You must be signed in to change notification settings - Fork 59
network matcher doc #201
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
network matcher doc #201
Conversation
Codecov Report
@@ Coverage Diff @@
## master #201 +/- ##
==========================================
+ Coverage 74.64% 75.62% +0.97%
==========================================
Files 40 40
Lines 852 886 +34
Branches 205 221 +16
==========================================
+ Hits 636 670 +34
Misses 203 203
Partials 13 13
Continue to review full report at Codecov.
|
christian-bromann
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Given the following example:
expect(mock).toBeRequestedWith({
url: 'http://localhost:8080/api/todo', // [optional] string | function | custom matcher
method: 'POST', // [optional] string | array
requestHeaders: { Authorization: 'foo' }, // [optional] object | function | custom matcher
responseHeaders: { Authorization: 'bar' }, // [optional] object | function | custom matcher
request: { title: 'foo', description: 'bar' }, // [optional] object | function | custom matcher
response: { success: true }, // [optional] object | function | custom matcher
})What is the request property suppose to represent here? The request payload or its params? Maybe it is more clear if it is called requestPayload.
We can do a separate PR for it. These docs changes look good 👍
|
It represents the request payload. |
|
@mgrybyk |
|
@christian-bromann merged this one because webdriverio/webdriverio#5818 is merged |
## Network Matcherssection (please review!)#185