fix: resolve ignore* presets with resemble last-wins semantics#1177
Merged
wswebcreation merged 1 commit intoJul 4, 2026
Merged
Conversation
- apply last-wins threshold and AA rules for ignoreLess, ignoreAlpha, ignoreColors, and ignoreNothing - keep forgiving default when only ignoreAntialiasing applies - add unit and executeImageCompare integration tests - add patch changeset for image-comparison-core and visual-service
🦋 Changeset detectedLatest commit: 7800494 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After #1175, pixelmatch threshold and AA forgiveness were derived independently from each flag in the ignore list. Combined modes such as
ignoreLesswith the defaultignoreAntialiasing: truestill inherited AA forgiveness instead of following resemble's last-wins preset model.What changed
resolveComparePresetwith resemble last-wins ordering matchingprepareIgnoreOptionsignoreLess,ignoreAlpha,ignoreColors, andignoreNothingnow apply their own threshold and AA rules when activeignoreAntialiasing: truestill uses the forgiving preset; explicitignoreAntialiasing: falsestays strict