Add types for functions #26
Conversation
types/index.d.ts
Outdated
| @@ -1,43 +1,43 @@ | |||
| declare module WebdriverIO { | |||
| interface Browser { | |||
| /** | |||
There was a problem hiding this comment.
Thanks for the Pr, the output is not 100% correct, it also depends on what the config was, please check https://github.com/wswebcreation/wdio-image-comparison-service#test-result-outputs, can you also add that
There was a problem hiding this comment.
Can you please check now: f295c91
I try to consider all the options.
There was a problem hiding this comment.
This looks good, did you verify if it works? If so I can merge it and release it.
Thanks for the work
There was a problem hiding this comment.
So, it looks good but works bad =)
It's always choosing number.
There are two options:
simple - use any for check functions,
complicated - we can divide check(...): number and check(...): {} but values which function takes should differ functions. This complicates to do because of parameter returnAllCompareData in the config and we can know it just in compile time.
There was a problem hiding this comment.
I created a new PR with all the types, can you take a look at it? #27
Tnx
|
Closing this in favor of #27 |
2 participants
Add 'void' and 'numbers' types for functions