Skip to content

Conversation

@wswebcreation
Copy link
Member

This PR is adding all the types, so in favour of #26.

It will now even give warnings on the options, see
image
image
image

and on the output

image
image

@wswebcreation
Copy link
Member Author

@balukov and @mvgiacomello

Can you please verify this one, I added all the types and I think it should work now

@balukov
Copy link

balukov commented Mar 7, 2020

@balukov and @mvgiacomello

Can you please verify this one, I added all the types and I think it should work now

I think it's a good idea to use interfaces from "webdriver-image-comparison"
I already thank about this.
I can check later how good it works for return object/numbers, because in my case almost this construction should return just numbers.

@balukov
Copy link

balukov commented Mar 10, 2020

[0-0] 2020-03-10T14:11:17.676Z ERROR @wdio/runner: TSError: ⨯ Unable to compile TypeScript: specs/visual/base.spec.ts(14,25): error TS2339: Property 'checkScreen' does not exist on type 'BrowserObject'.

I use async mode, but I tried in sync mode too.

@wswebcreation
Copy link
Member Author

[0-0] 2020-03-10T14:11:17.676Z ERROR @wdio/runner: TSError: ⨯ Unable to compile TypeScript: specs/visual/base.spec.ts(14,25): error TS2339: Property 'checkScreen' does not exist on type 'BrowserObject'.

I use async mode, but I tried in sync mode too.

Hmm, need to look into this further. The sync was working on my machine, I haven't thought about the async one because I never use it 🤣

@balukov
Copy link

balukov commented Mar 11, 2020

I use async mode, but I tried in sync mode too.

My mistake: of course, I use sync mode.
If it's work for you - merge it and I'll test it.

@wswebcreation
Copy link
Member Author

Ok, will release it

@wswebcreation wswebcreation merged commit 788116d into master Mar 11, 2020
@wswebcreation wswebcreation deleted the feat/add-all-typings branch March 11, 2020 17:52
@wswebcreation
Copy link
Member Author

wswebcreation commented Mar 11, 2020

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants