Skip to content

chore: remove duplicated expect-webdriverio type#799

Merged
wswebcreation merged 1 commit intowebdriverio:mainfrom
alcpereira:chore/remove-duplicated-type-expect-wdio
Mar 30, 2025
Merged

chore: remove duplicated expect-webdriverio type#799
wswebcreation merged 1 commit intowebdriverio:mainfrom
alcpereira:chore/remove-duplicated-type-expect-wdio

Conversation

@alcpereira
Copy link
Copy Markdown
Contributor

While working on bumping ESLint, the any from this interface was causing some issues.

This type is a duplicate of the one already in expect-webdriverio. As we actually already include this package, this should not have any impact, and actually make it more clear that visual-service extends the matchers.

$ pnpm why expect-webdriverio
@wdio/visual-service link:packages/visual-service
└─┬ @wdio/globals 9.9.1
  └── expect-webdriverio 5.1.0

Copy link
Copy Markdown
Member

@wswebcreation wswebcreation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tnx, LGTM

@wswebcreation wswebcreation merged commit 7ba1555 into webdriverio:main Mar 30, 2025
14 of 19 checks passed
@wdio-bot
Copy link
Copy Markdown
Contributor

Hey alcpereira 👋

Thank you for your contribution to WebdriverIO! Your pull request has been marked as an "Expensable" contribution.

We've sent you an email with further instructions on how to claim your expenses from our development fund.
Please make sure to check your spam folder as well. If you have any questions, feel free to reach out to us at expense@webdriver.io or in the contributing channel on Discord.

We are looking forward to more contributions from you in the future 🙌

Have a nice day,
The WebdriverIO Team 🤖

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants