Skip to content

Redirect generated XML artifacts to gitignored test output directory #151

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Copilot wants to merge 5 commits into from
Closed

Redirect generated XML artifacts to gitignored test output directory #151

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
be363e3
Plan for issue #150 fix
Copilot May 22, 2026
4dce40e
Redirect root XML outputs to test output dir
Copilot May 22, 2026
eb2aa0d
Ignore generated example.musicxml in test output
Copilot May 22, 2026
e86ef2f
Remove checked-in generated example.musicxml artifacts
Copilot May 22, 2026
4cc6ee1
Apply formatter output for RoundTrip header
Copilot May 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions data/testOutput/.gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
*.csv
*.txt
*.xml
*.musicxml
4 changes: 2 additions & 2 deletions src/private/mx/examples/Write.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,10 +121,10 @@ int main(int argc, const char *argv[])
#endif

// write to a file
mgr.writeToFile(documentID, "./example.musicxml");
mgr.writeToFile(documentID, "./data/testOutput/example.musicxml");

// we need to explicitly delete the object held by the manager
mgr.destroyDocument(documentID);

return 0;
}
}
Copy link
Copy Markdown
Owner

@webern webern May 22, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@copilot

Suggested change
}
}

Copy link
Copy Markdown
Author

Copilot AI May 22, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

src/private/mx/examples/Write.cpp already ends with a trailing newline. I verified this locally and re-ran make check; there is no remaining diff to apply for this suggestion.

4 changes: 3 additions & 1 deletion src/private/mxtest/api/DocumentManagerTest.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -187,7 +187,9 @@ TEST( sillyTest, DocumentManager )
score.encoding.encodingDate.day = 30;
score.copyright = "© 2016 by Matthew James Briggs";
auto documentId = DocumentManager::getInstance().createFromScore( score );
DocumentManager::getInstance().writeToFile( documentId, "./sillytest.xml" );
const std::string outputPath = std::string{mxtest::getResourcesDirectoryPath()} + "testOutput" +
FILE_PATH_SEPARATOR + "sillytest.xml";
DocumentManager::getInstance().writeToFile( documentId, outputPath );
DocumentManager::getInstance().destroyDocument( documentId );
}
T_END
Expand Down
5 changes: 4 additions & 1 deletion src/private/mxtest/api/RoundTrip.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@
#include "mx/api/DocumentManager.h"
#include "mxtest/control/CompileControl.h"
#include "mxtest/file/MxFileRepository.h"
#include "mxtest/file/Path.h"
#include <sstream>

namespace mxtest
Expand All @@ -21,7 +22,9 @@ inline void roundTrip()
auto scoreData = docMgr.getData(docId);
docMgr.destroyDocument(docId);
docId = docMgr.createFromScore(scoreData);
docMgr.writeToFile(docId, "./output.xml");
const std::string outputPath =
std::string{mxtest::getResourcesDirectoryPath()} + "testOutput" + FILE_PATH_SEPARATOR + "output.xml";
docMgr.writeToFile(docId, outputPath);
docMgr.destroyDocument(docId);
}

Expand Down