Skip to content

fix: Meeting Title margin issue in in-meeting component #844

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rsarika merged 2 commits into from
Oct 16, 2024
Merged

fix: Meeting Title margin issue in in-meeting component #844

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8d68684
fix: updated margin
rsarika Oct 16, 2024
3ff9415
fix: corrected snapshot
rsarika Oct 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/components/WebexInMeeting/WebexInMeeting.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,10 @@ $shadow-color: rgba(0, 0, 0, 0.2);
min-height: auto;
background: var(--wxc-secondary-video-background);
}

.#{$C}__info {
Copy link
Contributor

@sreenara sreenara Oct 16, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this name formatted this way?

Copy link
Contributor Author

@rsarika rsarika Oct 16, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

$C:
they just used 'C' as variable for below
#{$WEBEX_COMPONENTS_CLASS_PREFIX}-in-meeting;
final string is : webex-in-meeting__info
'__info' : Its an element
Element: An element is a part of the block that has no standalone meaning and is semantically tied to its block. Elements are denoted by double underscores (__). For example, info is an element of the block.(Chat GPT :))

margin-bottom: 1rem;
}

&--tablet {
.#{$C}__local-media-in-meeting {
@include media-preview-tablet();
Expand Down