fix(cc-widgets): End 2 End Tests stabilised by rsarika · Pull Request #517 · webex/widgets

rsarika · 2025-08-15T17:55:52Z

COMPLETES #https://jira-eng-sjc12.cisco.com/jira/browse/CAI-6525

This pull request addresses

refactoring e2e tests to make them stable and reduce execution time.

by making the following changes

created a testmanager to have all the apge setup logic at one place.
updated config with 5 threads(workers
).

Change Type

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to change)
Documentation update
Tooling change
Internal code refactor

The following scenarios were tested

The testing is done with the amplify link
< ENUMERATE TESTS PERFORMED, WHETHER MANUAL OR AUTOMATED >

The GAI Coding Policy And Copyright Annotation Best Practices

Checklist before merging

I have not skipped any automated checks
All existing and new tests passed
I have updated the testing document

…-fixes

coderabbitai · 2025-08-15T17:56:00Z

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing Touches

🧪 Generate unit tests

Create PR with unit tests
Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbitai help to get the list of available commands.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

Status, Documentation and Community

Visit our Status Page to check the current availability of CodeRabbit.
Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

aws-amplify-us-east-2 · 2025-08-15T18:01:07Z

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-517.d1b38q61t1z947.amplifyapp.com

…-fixes

Shreyas281299 · 2025-08-21T06:45:18Z

@CodeRabbit review

Shreyas281299

Thanks for this. I really like these changes for timeouts and the suites.
Just some minor changes request. But mostly this looks good

Shreyas281299 · 2025-08-21T06:38:15Z

+npx playwright test --grep "@chat"     # Chat tests only
+npx playwright test --grep "@telephony" # Voice tests only


Do we have this feature? I tried running this locally and it doesnt get any tests, fails with no test found. I think we can remove this part of filter by tag.

addressed updated this section properly

Shreyas281299 · 2025-08-21T07:04:51Z

+  EXTENSION: 'extension',
+  CHAT: 'chat',
+  MULTI_SESSION: 'multiSession',
+} as const;


I dont think we need this as const in the above two objects

Shreyas281299 · 2025-08-21T07:04:57Z

+  CHAT_EMAIL: 'playwright@test.com',
+  EMAIL_TEXT: '--This Email is generated due to playwright automation test for incoming Tasks---',
+  EXTENSION_CALL_INDICATOR: 'Ringing...',
+} as const;


Shreyas281299 · 2025-08-21T07:07:30Z

+  fs.writeFileSync(envPath, envContent, 'utf8');
+}
+
+module.exports = {UpdateENVWithUserSets};


Why are we exporting like this? We can just put export const function

Shreyas281299 · 2025-08-21T07:08:21Z

  }
 });
+
+UpdateENVWithUserSets();


Rather than here, Can we put this inside the setup('OAuth') step?

mkesavan13

Please address the review comments by both me and Shreyas.

Rest looks good

mkesavan13 · 2025-08-19T11:26:08Z

-      name: 'Test: Chrome',
-      // Run all tests except advanced tests and transfer/consult tests on Chrome
-      testIgnore: [/advanced-task-controls-test\.spec\.ts/],
+      name: 'SET_1',


Can we have one config JSON and then loop them through for all these projects? That way, we need not modify any same config for 5 times or more in future?

great suggestion. addressed by moving the suite file name to testdata and reading threads and projects from testdata dynamically.

mkesavan13 · 2025-08-19T11:27:23Z

-  workers: 1,
-  /* Reporter to use. See https://playwright.dev/docs/test-reporters */
+  fullyParallel: true,
+  workers: 5,


Should we have 6 workers considering OAuth: Get Access Token being one of the projects?

OAuth: Get Access Token, is the dependency for all the projects . so it should complete before any project starts.

# [1.28.0-ccwidgets.110](v1.28.0-ccwidgets.109...v1.28.0-ccwidgets.110) (2025-08-22) ### Bug Fixes * **cc-widgets:** End 2 End Tests stabilised ([#517](#517)) ([4dd2f74](4dd2f74))

sreenara · 2025-08-22T08:01:42Z

🎉 This PR is included in version 1.28.0-ccwidgets.110 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

rsarika added 12 commits August 8, 2025 12:05

fix: chat client e2e created

769ec62

fix: url

ea7e27f

Merge branch 'ccwidgets' of https://github.com/webex/widgets into e2e…

092c4ec

…-fixes

fix: e2e tests refactored

623418a

fix: refactored code

158683a

fix: updated test data

50b4d04

fix: updated test data and pull-request yml

1935a39

fix: fixed multi session page issue

002e458

Merge branch 'ccwidgets' of https://github.com/webex/widgets into e2e…

246c414

…-fixes

fix: refactored test manager

6af12ca

fix: refactored code

871e0f4

fix: refactor test data

467a3a5

rsarika added the validated Indicates that the PR is ready for actions label Aug 15, 2025

rsarika added 5 commits August 19, 2025 07:01

Merge branch 'ccwidgets' of https://github.com/webex/widgets into e2e…

1387459

…-fixes

fix: updated task-list according to new structure

a0b2bfb

fix: taskList test fixed

7e1335c

fix: updated env variable names

8e9fe43

Merge branch 'ccwidgets' of https://github.com/webex/widgets into e2e…

1abc46d

…-fixes

rsarika added the run_e2e Add this label to run E2E test for meeting and CC widgets label Aug 19, 2025

rsarika changed the title ~~fix: End 2 End Tests stabilised~~ fix(cc-widgets): End 2 End Tests stabilised Aug 19, 2025

rsarika added validated Indicates that the PR is ready for actions run_e2e Add this label to run E2E test for meeting and CC widgets and removed validated Indicates that the PR is ready for actions run_e2e Add this label to run E2E test for meeting and CC widgets labels Aug 19, 2025

rsarika added 4 commits August 19, 2025 13:18

fix: stray tasks

855607f

fix: removed unnecessary describe blocks

150a083

fix: removed extra timeout

b46b198

fix: removed extra timeouts

2f14f04

rsarika added 4 commits August 19, 2025 16:58

removed extra timeouts

ba33687

fix: updated testdata

a3b3fa8

fix: renamed files

6331003

fix: updated folder structure

49cf52e

Shreyas281299 approved these changes Aug 21, 2025

View reviewed changes

fix: addressed comments

4a82eef

mkesavan13 approved these changes Aug 22, 2025

View reviewed changes

fix: updated

9d73db1

mkesavan13 merged commit 4dd2f74 into webex:ccwidgets Aug 22, 2025
12 of 15 checks passed

sreenara added the released on @ccwidgets label Aug 22, 2025

		npx playwright test --grep "@chat" # Chat tests only
		npx playwright test --grep "@telephony" # Voice tests only

Uh oh!

Conversation

rsarika commented Aug 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

COMPLETES #https://jira-eng-sjc12.cisco.com/jira/browse/CAI-6525

This pull request addresses

by making the following changes

Change Type

The following scenarios were tested

The GAI Coding Policy And Copyright Annotation Best Practices

Checklist before merging

Uh oh!

coderabbitai Bot commented Aug 15, 2025

Review skipped

Chat

Support

CodeRabbit Commands (Invoked using PR/Issue comments)

Other keywords and placeholders

Status, Documentation and Community

Uh oh!

aws-amplify-us-east-2 Bot commented Aug 15, 2025

Uh oh!

Shreyas281299 commented Aug 21, 2025

Uh oh!

Shreyas281299 left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mkesavan13 left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

sreenara commented Aug 22, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

rsarika commented Aug 15, 2025 •

edited

Loading

Shreyas281299 left a comment •

edited

Loading