feat(cc-digital-channel): add digital channel package by akulakum · Pull Request #586 · webex/widgets

akulakum · 2025-12-16T14:42:14Z

COMPLETES #https://jira-eng-sjc12.cisco.com/jira/browse/CAI-7419

Vidcast Link: https://app.vidcast.io/share/a82fefc6-9482-429d-bb23-29f74c7d6183

This pull request addresses

This PR is to consume engage npm packag and expose the digital widget as part of cc-widgets

< DESCRIBE THE CONTEXT OF THE ISSUE >
consumed "@webex-engage/wxengage-conversations": "^1.0.2", added yarnrc t o have cisco repository config and token.

by making the following changes

Created a new package @webex/cc-digital-channels and consumed "@webex-engage/wxengage-conversations": "^1.0.2"

< DESCRIBE YOUR CHANGES >

Change Type

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to change)
Documentation update
Tooling change
Internal code refactor

The following scenarios were tested

The testing is done with the amplify link
< ENUMERATE TESTS PERFORMED, WHETHER MANUAL OR AUTOMATED >

The GAI Coding Policy And Copyright Annotation Best Practices

Checklist before merging

I have not skipped any automated checks
All existing and new tests passed
I have updated the testing document
I have tested the functionality with amplify link

Make sure to have followed the contributing guidelines before submitting.

Shreyas281299 · 2025-12-22T08:21:30Z

@@ -0,0 +1,13 @@
+// Declare custom HTML elements used by the Webex Engage components


Since we wont require md-theme, we can get rid of this file as well

Not sure if this comment is still applicable... but if so, we can remove this file.

Lets check this please.

We do require md-theme. It is required. Since it's a old momentum. We need to add the types explicitly.

Shreyas281299 · 2025-12-22T08:25:24Z

+import {mockTask, mockCC} from '@webex/test-fixtures';
+
+// Mock mobx-react-lite to make observer work properly in tests
+jest.mock('mobx-react-lite', () => ({


Can we avoid this, we wanna make sure the store changes are being recevied by the widget

We are still mocking the store, can we remove that

Shreyas281299 · 2025-12-22T08:26:13Z

+  it('should successfully load and initialize real Engage component without errors', () => {
+    // This test proves we can test with the real Engage component
+    expect(() => {
+      render(<DigitalChannels {...mockProps} />);


Can we check something in the dom to ensure the widget is loaded

Same here, just expecting no error wont gauranteee the widget has actually reached the dom

…AL_CHANNEL

aws-amplify-us-east-2 · 2026-01-27T06:48:20Z

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-586.d1b38q61t1z947.amplifyapp.com

rsarika · 2026-01-28T05:47:05Z

 import {createRoot} from 'react-dom/client';
+
+// Initialize AGENTX_SERVICE before any imports that might need it
+window['AGENTX_SERVICE'] = {}; // Required by engage widgets


lets revisit this after Rajeev comeback if he can fix it

rsarika · 2026-01-28T05:51:24Z

+ *
+ * @returns The normalized region string (e.g., 'produs1', 'intgus1') or undefined if parsing fails
+ */
+export function extractRegionFromRtmsDomain(domain: string): string | undefined {


Lets revisit and discuss with team, how to do it more effectively

adhmenon

Overall code is LGTM.
Suggested few code changes.

Again, main thing to discuss is the getDataCenter method, ideally we should compute it in the SDK.
Have discussed with Ravi over the call and we are aware of the current method workaround.

adhmenon · 2026-01-29T10:09:42Z

@@ -0,0 +1,35 @@
+import {ITask} from '@webex/cc-store';
+
+export interface UseDigitalChannelsInitProps {


Nit: Maybe we can rename this and remove the Use part from the names.

I agree, Im assuming this is for hook. We were using this naming convention in web-client, in this repo we just use the work hook

Suggested change

export interface UseDigitalChannelsInitProps {

export interface DigitalChanelsHooksProps {

adhmenon · 2026-01-29T10:13:50Z

+import {DigitalChannelsComponent} from './DigitalChannelsComponent';
+import {DigitalChannelsProps} from './digital-channels.types';
+
+const DigitalChannelsInternal: React.FunctionComponent<DigitalChannelsProps> = observer(({currentTheme}) => {


Is it possible to move this to another file just for organisation perspective perhaps.

adhmenon · 2026-01-29T10:14:20Z

@@ -0,0 +1,13 @@
+// Declare custom HTML elements used by the Webex Engage components


Not sure if this comment is still applicable... but if so, we can remove this file.

adhmenon · 2026-01-29T10:17:17Z

@@ -0,0 +1,10 @@
+// This config is to do type checking in our files while running tests.


Maybe we can remove some of these comments.

Shreyas281299 · 2026-02-02T05:24:57Z

@@ -0,0 +1,35 @@
+import {ITask} from '@webex/cc-store';
+
+export interface UseDigitalChannelsInitProps {


I agree, Im assuming this is for hook. We were using this naming convention in web-client, in this repo we just use the work hook

Suggested change

export interface UseDigitalChannelsInitProps {

export interface DigitalChanelsHooksProps {

Shreyas281299 · 2026-02-02T05:27:22Z

+
+  return (
+    <div>
+      <md-theme id="app-theme" theme="momentumV2" {...(isDarkTheme ? {darktheme: true} : {lighttheme: true})}>


Did we confirm if this is required? To use widgets we have asked dev to wrap the app in Theme and Icon Provider, so if a developer does that and here we are again wrapping the component that mean the Engage widget is wrapped twice. Just wanna ensure this doesnt break anything. Maybe its worthwhile to check with momentum team about this, We are wrapping a web-component in a react component.

Confirmed with Digital Channels team. They strictly require this. Engage Widget should be wrapped inside the md-theme.

Shreyas281299 · 2026-02-02T05:28:19Z

@@ -0,0 +1,13 @@
+// Declare custom HTML elements used by the Webex Engage components


Lets check this please.

Shreyas281299 · 2026-02-02T05:29:15Z

+      // Initialize the digital channels app only once per session
+      if (!isDigitalChannelsInitialized) {
+        logger.log(
+          `[DIGITAL_CHANNELS_INIT] 🚀 Starting Digital Channels initialization for the FIRST TIME (dataCenter: ${dataCenter})...`,


Can we not have emogis in logs.

Shreyas281299 · 2026-02-02T05:38:59Z

+import {mockTask, mockCC} from '@webex/test-fixtures';
+
+// Mock mobx-react-lite to make observer work properly in tests
+jest.mock('mobx-react-lite', () => ({


We are still mocking the store, can we remove that

Shreyas281299 · 2026-02-02T05:39:28Z

+  it('should successfully load and initialize real Engage component without errors', () => {
+    // This test proves we can test with the real Engage component
+    expect(() => {
+      render(<DigitalChannels {...mockProps} />);


Same here, just expecting no error wont gauranteee the widget has actually reached the dom

Shreyas281299 · 2026-02-02T05:39:42Z

+  it('should demonstrate minimal mocking approach', () => {
+    // This test suite demonstrates that we only needed to mock:
+    // 1. AGENTX_SERVICE global (minimal requirement)
+    // 2. @webex/cc-store (external dependency)
+    // 3. mobx-react-lite observer (to simplify MobX in tests)
+    expect(true).toBe(true); // Placeholder assertion


This test doesnt have anything

Basic UTs have now been added. We have a separate ticket to cover UTs for all components related to the Digital Channel feature.

Jira ticket: https://jira-eng-sjc12.cisco.com/jira/browse/CAI-7458

Shreyas281299 · 2026-02-02T05:44:18Z

I see we have reduced the file, but still this would need to be done to use digital cahnnel?

akulakum · 2026-02-03T06:07:43Z

Overall code is LGTM. Suggested few code changes.

Again, main thing to discuss is the getDataCenter method, ideally we should compute it in the SDK. Have discussed with Ravi over the call and we are aware of the current method workaround.

No longer valid. Now getting the dataCenter value from the Agent Profile

akulakum added 2 commits December 16, 2025 20:03

feat(cc-digital-channel): add-new-package

43946ca

feat(cc-digital-channel): update-yarn-lock-file

eb2e774

akulakum added the validated Indicates that the PR is ready for actions label Dec 17, 2025

akulakum and others added 4 commits December 18, 2025 16:05

feat(cc-digital-channel): remove-static-values

1bca291

feat(cc-digital-channel): fix-digital-channel-responsive

7a694f1

Merge branch 'next' into CC_DIGITAL_CHANNEL

efb887c

feat(cc-digital-channel): initalize-digital-app-once

5ab4742

Shreyas281299 requested changes Dec 22, 2025

View reviewed changes

akulakum and others added 14 commits December 23, 2025 16:14

feat(cc-digital-channel): change-from-vite-to-weback-config

f8f12a7

feat(cc-digital-channel): update-yarn-yml-file

f0432e0

feat(cc-digital-channel): add-presentational-layer

598aa3f

Merge branch 'next' into CC_DIGITAL_CHANNEL

6273e60

feat(cc-digital-channel): fix-style-issue

d3e037d

feat(cc-digital-channel): update-beta-version

cd2bbd7

feat(cc-digital-channel): add-visual-rebrand

199a7e0

Merge branch 'next' into CC_DIGITAL_CHANNEL

10fca07

feat(cc-digital-channel): get-access-token-from-store

97e4ac7

Merge branch 'next' of github.com:webex/widgets into CC_DIGITAL_CHANNEL

085cb53

feat(cc-digital-channel): get-datacenter-from-store

eeb2ad1

Merge branch 'next' into CC_DIGITAL_CHANNEL

402aea9

fix: updated with public package

08cdf82

Merge branch 'next' of https://github.com/webex/widgets into CC_DIGIT…

c1ea8d0

…AL_CHANNEL

rsarika reviewed Jan 28, 2026

View reviewed changes

akulakum and others added 4 commits January 28, 2026 17:20

Merge branch 'next' into CC_DIGITAL_CHANNEL

9b47030

Merge branch 'next' into CC_DIGITAL_CHANNEL

94ca387

feat(cc-digital-channel): remove-console-log

01e6c63

feat(cc-digital-channel): implement-datacenter-logic

f052ab8

rsarika requested a review from Shreyas281299 February 2, 2026 04:19

rsarika approved these changes Feb 2, 2026

View reviewed changes

adhmenon reviewed Feb 2, 2026

View reviewed changes

adhmenon approved these changes Feb 2, 2026

View reviewed changes

Shreyas281299 reviewed Feb 2, 2026

View reviewed changes

Merge branch 'next' into CC_DIGITAL_CHANNEL

c9ac3ff

akulakum and others added 3 commits February 3, 2026 12:32

Merge branch 'next' into CC_DIGITAL_CHANNEL

f2a9020

feat(cc-digital-channel): address-review-comments

f501c60

Merge branch 'next' into CC_DIGITAL_CHANNEL

2d8709f

akulakum requested a review from Shreyas281299 February 3, 2026 08:11

Merge branch 'next' into CC_DIGITAL_CHANNEL

4cfe337

Shreyas281299 approved these changes Feb 4, 2026

View reviewed changes

Shreyas281299 changed the title ~~feat(cc-digital-channel): add-new-package~~ feat(cc-digital-channel): add digital channel package Feb 4, 2026

Shreyas281299 merged commit cdb3858 into webex:next Feb 4, 2026
8 checks passed

		@@ -0,0 +1,13 @@
		// Declare custom HTML elements used by the Webex Engage components

		@@ -0,0 +1,35 @@
		import {ITask} from '@webex/cc-store';

		export interface UseDigitalChannelsInitProps {

	export interface UseDigitalChannelsInitProps {
	export interface DigitalChanelsHooksProps {

		@@ -0,0 +1,10 @@
		// This config is to do type checking in our files while running tests.

Conversation

akulakum commented Dec 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

COMPLETES #https://jira-eng-sjc12.cisco.com/jira/browse/CAI-7419

This pull request addresses

by making the following changes

Change Type

The following scenarios were tested

The GAI Coding Policy And Copyright Annotation Best Practices

Checklist before merging

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

akulakum Feb 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

aws-amplify-us-east-2 Bot commented Jan 27, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

adhmenon left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

akulakum commented Dec 16, 2025 •

edited

Loading

akulakum Feb 3, 2026 •

edited

Loading