feat(cc-widgets): Add multi-party conference E2E suites for SET_7 and SET_8 by rsarika · Pull Request #624 · webex/widgets

rsarika · 2026-02-18T02:18:26Z

COMPLETES #https://jira-eng-sjc12.cisco.com/jira/browse/CAI-7322

This pull request addresses

Missing and uneven multi-party conference E2E coverage for the conference matrix scenarios, where tests were not logically split for parallel execution by set, and conference merge actions could intermittently fail due to missing button readiness checks.

by making the following changes

Added a shared multi-party conference E2E implementation in playwright/tests/conference-transfer-switch-test.spec.ts.
Split coverage into two logical suites for parallel runs:
- SET_7: MPC scenarios (CTS-MPC-01..16)
- SET_8: Transfer + Switch scenarios (CTS-TC-01..05, CTS-SW-01..05)
Added suite files under playwright/suites/ following existing structure:
- conference-mpc-transfer-tests.spec.ts
- conference-switch-tests.spec.ts
Updated set mappings in playwright/test-data.ts for SET_7 and SET_8.
Added conference desktop setup support in playwright/test-manager.ts for 4-agent conference flows.
Added explicit merge-button readiness validation (visible + enabled) before merge click in conference setup flows.
Kept out-of-scope cases as expected skip/fixme per agreed scope (TC14, TC20, TC17-19).

The following scenarios were tested

yarn test:e2e --project=SET_7
yarn test:e2e --project=SET_8
yarn test:e2e --project=SET_7 --project=SET_8

Result:

Combined execution passed with expected skip/fixme cases only.

…t-spec

aws-amplify-us-east-2 · 2026-02-18T02:24:23Z

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-624.d1b38q61t1z947.amplifyapp.com

rsarika · 2026-02-18T06:10:31Z

@codex review

chatgpt-codex-connector · 2026-02-18T06:10:36Z

To use Codex here, create a Codex account and connect to github.

akulakum

PR Review: feat(cc-widgets): Add multi-party conference E2E suites for SET_7 and SET_8

Summary

Good test coverage for multi-party conference scenarios. The PR adds comprehensive E2E tests for MPC, transfer, and switch flows with proper retry patterns and cleanup handling.

Critical Issues (Must Fix)

Missing global.setup.ts updates - setupForConferenceDesktop expects AGENT3_ACCESS_TOKEN and AGENT4_ACCESS_TOKEN, but global.setup.ts only handles AGENT1/AGENT2 OAuth flows. SET_7/SET_8 tests will fail at runtime.
Missing PAGE_TYPES updates - constants.ts needs AGENT3 and AGENT4 page types for consistency with TestManager changes.

Medium Issues

skipOAuth should be environment-driven - Currently hardcoded; should use process.env.PW_SKIP_OAUTH
Excessive waitForTimeout usage - ~15+ occurrences of hardcoded waits; prefer explicit condition waits for reliability
Helper functions should be extracted - setAgentState, ensureAgentsIdle, submitWrapupIfVisible, clickMergeWhenReady could be reusable utilities in Utils/conferenceUtils.ts

Minor Issues

Factory pattern deviation - New parameterized factory differs from existing convention (functional but inconsistent)
5-minute test timeout - Consider per-test timeouts instead of blanket 300s
Missing env var validation in getAgentNames()

Documentation Issues

Set-to-suite mapping outdated - playwright/ai-docs/AGENTS.md and ai-docs/templates/playwright/00-master.md don't include SET_7/SET_8 mappings
Missing setupForConferenceDesktop in TestManager methods list in docs

Positive Observations

✅ Good retry patterns in createInboundAndAccept and consultAgentWithRetry
✅ Proper error handling with .catch(() => {})
✅ Parallel context creation for performance
✅ Explicit merge-button readiness validation (addresses flakiness mentioned in PR description)
✅ Clear test naming convention (CTS-MPC-01, CTS-TC-01, etc.)
✅ Well-structured Playwright template hierarchy in ai-docs/templates/playwright/

akulakum · 2026-02-19T07:15:07Z

+
+export type ConferenceSuiteGroup = 'all' | 'mpc' | 'transfer-switch' | 'mpc-transfer' | 'switch';
+
+async function setAgentState(page: Page, state: string): Promise<void> {


Suggestion: These helper functions (setAgentState, ensureAgentsIdle, submitWrapupIfVisible, clickMergeWhenReady, etc.) are generic and reusable.

Consider extracting them to Utils/conferenceUtils.ts for consistency with existing utility patterns and reusability in future conference tests.

// playwright/Utils/conferenceUtils.ts export async function setAgentState(page: Page, state: string): Promise<void> { ... } export async function ensureAgentsIdle(pages: Page[]): Promise<void> { ... } export async function submitWrapupIfVisible(page: Page): Promise<void> { ... } export async function clickMergeWhenReady(ownerPage: Page): Promise<void> { ... }

Shreyas281299 · 2026-02-20T05:15:36Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: a1ae3d74d4

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 5f5fe689c8

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: be6585adf8

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

chatgpt-codex-connector · 2026-03-07T14:59:24Z

+      await Promise.race([handleStrayTasks(page, validAuxiliaryPage), timeoutPromise]);
+    } catch {


Prevent timed-out cleanup from leaking into next test

safeHandleStrayTasks uses Promise.race with a 60s timeout, but when the timeout wins, handleStrayTasks(...) keeps running in the background because it is never canceled. In that case beforeEach/afterEach can return and the next test starts while the previous cleanup is still clicking end/wrapup controls on the same pages, which creates nondeterministic cross-test interference and flaky conference results.

Useful? React with 👍 / 👎.

…rty-conference-e2e-tests

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 121ac907ba

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 3caeeb4e06

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 8b001150dd

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 9b9fb612e1

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 05ebcfc147

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 855e4f0464

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

…rty-conference-e2e-tests

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 66e28c39bb

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 6812bca655

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

chatgpt-codex-connector · 2026-03-10T11:07:30Z

+  private async runBestEffortWithTimeout(operation: () => Promise<void>, timeout: number = OPERATION_TIMEOUT): Promise<void> {
+    const guardedOperation = operation().catch(() => {});
+    const timeoutGuard = new Promise<void>((resolve) => setTimeout(resolve, timeout));
+    await Promise.race([guardedOperation, timeoutGuard]);


Clear timeout guard after best-effort race returns

runBestEffortWithTimeout schedules a setTimeout for each call but never clears it when operation() finishes first. Since safeHandleStrayTasks/safeStationLogout call this repeatedly during softCleanup() and cleanup(), successful cleanups still leave many 30s+ active timers, which can keep the worker event loop alive and noticeably delay or hang teardown at suite end. Store the timeout handle and clearTimeout it once the raced operation settles.

Useful? React with 👍 / 👎.

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 1715146b51

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

chatgpt-codex-connector · 2026-03-10T15:53:35Z

+      hasVisibleEndControl: false,
+      hasVisibleWrapup: true,


Don't require all end controls to disappear before wrap-up

waitForWrapupAfterCallEnd currently requires hasVisibleEndControl: false before it succeeds, but these flows can still have a visible (often disabled) end-call control while wrap-up is already the correct actionable state; this commit’s other control-handling code already accounts for that pattern. With the new call-site in incoming telephony, this strict condition can timeout healthy call-end flows and fail tests even when wrap-up is ready. Gate on wrap-up readiness instead of full end-control disappearance.

Useful? React with 👍 / 👎.

chatgpt-codex-connector · 2026-03-10T15:53:35Z

+        const hasEndControl = await getAgentPage(1)
+          .getByTestId('call-control:end-call')
+          .first()
+          .isVisible()


Check any visible end control in baseline call readiness

startBaselineCallOnAgent1 validates readiness using only call-control:end-call.first(). In conference layouts with multiple control groups, the first match can be hidden while another end control is visible/enabled (which is why this commit added multi-control scans in other helpers), so hasEndControl can stay false and the readiness poll times out despite a valid active call. Scan all matching end controls (or reuse the shared visible-control helper) before failing baseline setup.

Useful? React with 👍 / 👎.

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 1c36e05221

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

chatgpt-codex-connector · 2026-03-10T17:33:10Z

+  const controlCount = await controls.count().catch(() => 0);
+
+  for (let i = 0; i < controlCount; i++) {


Retry until consult/transfer control becomes actionable

openConsultOrTransferMenu now snapshots controls.count() once and immediately throws when no visible+enabled control is present, so it no longer waits for the consult/transfer button to appear after recent state transitions (for example, right after accept/merge/cancel). In these common timing windows the function fails with No visible enabled ... control found even though the control becomes actionable within the existing timeout budget, introducing avoidable flakiness across all consultOrTransfer(...) callers.

Useful? React with 👍 / 👎.

chatgpt-codex-connector · 2026-03-10T17:33:10Z

+          const hasEnd = await page
+            .getByTestId('call-control:end-call')
+            .first()
+            .isVisible()
+            .catch(() => false);


Detect post-disconnect controls across all rendered groups

This readiness check only inspects .first() for both call-control:end-call and call-control:wrapup-button, but conference pages can render multiple control groups where the first match is hidden while another instance is visible/enabled. In that layout, expectPostCustomerLeaveControls can timeout after customer disconnect even though valid end or wrap-up controls are already present, causing false failures in CTS-MPC-07/09/10.

Useful? React with 👍 / 👎.

rsarika added 4 commits February 10, 2026 09:15

feat: added agents.md and spec generator for playright e2e

3b19a9b

Merge branch 'next' of https://github.com/webex/widgets into playrigh…

b947723

…t-spec

docs: update playwright AGENTS and multiparty conference spec

c998f85

fix: updated spec

4f9eb65

rsarika added 4 commits February 18, 2026 10:15

docs: simplify playwright templates and consolidate ai-docs

701302d

revert(docs): remove web-component-patterns file

813d619

docs(playwright): update AGENTS with setup and env corrections

46f5222

docs(playwright): align architecture with page types and constants

9b3b4ed

rsarika added validated Indicates that the PR is ready for actions run_e2e Add this label to run E2E test for meeting and CC widgets labels Feb 18, 2026

akulakum requested changes Feb 19, 2026

View reviewed changes

chatgpt-codex-connector Bot reviewed Feb 20, 2026

View reviewed changes

Comment thread playwright/tests/conference-transfer-switch-test.spec.ts Outdated

rsarika requested a review from akulakum February 23, 2026 06:31

rsarika added 3 commits March 4, 2026 10:19

Merge upstream/next into playright-spec (take upstream AGENTS.md)

8b7aec5

feat: multiparty conference tests updated

2a910fb

docs(ai-docs): keep generic playwright docs and drop code deltas

adb3d19

rsarika force-pushed the multi-party-conference-e2e-tests branch from 218548a to adb3d19 Compare March 4, 2026 09:51

rsarika requested a review from a team as a code owner March 4, 2026 09:51

feat: implementation of multiparty conference

5f5fe68

chatgpt-codex-connector Bot reviewed Mar 5, 2026

View reviewed changes

Comment thread playwright/global.setup.ts Outdated

rsarika added 3 commits March 5, 2026 19:23

docs(playwright): address ciscoRankush review feedback

058e6ba

Merge origin/playright-spec into multi-party-conference-e2e-tests

b9198d0

fix: e2e tests

be6585a

chatgpt-codex-connector Bot reviewed Mar 7, 2026

View reviewed changes

Merge branch 'next' of https://github.com/webex/widgets into multi-pa…

121ac90

…rty-conference-e2e-tests

chatgpt-codex-connector Bot reviewed Mar 7, 2026

View reviewed changes

Comment thread playwright/Utils/advancedTaskControlUtils.ts

Comment thread playwright/global.setup.ts Outdated

rsarika added 2 commits March 9, 2026 15:14

fix: refactor the code

d101a6b

fix: error

3caeeb4

chatgpt-codex-connector Bot reviewed Mar 9, 2026

View reviewed changes

Comment thread playwright/tests/multiparty-conference-set-7-test.spec.ts

chatgpt-codex-connector Bot reviewed Mar 9, 2026

View reviewed changes

Comment thread playwright/Utils/conferenceUtils.ts

Comment thread playwright/Utils/conferenceUtils.ts

Comment thread playwright/tests/multiparty-conference-set-9-test.spec.ts

chatgpt-codex-connector Bot reviewed Mar 9, 2026

View reviewed changes

Comment thread playwright/Utils/conferenceUtils.ts

chatgpt-codex-connector Bot reviewed Mar 9, 2026

View reviewed changes

Comment thread playwright/Utils/conferenceUtils.ts

rsarika force-pushed the multi-party-conference-e2e-tests branch from 05ebcfc to 3caeeb4 Compare March 9, 2026 16:10

chatgpt-codex-connector Bot reviewed Mar 9, 2026

View reviewed changes

Comment thread playwright/Utils/conferenceUtils.ts

rsarika closed this Mar 10, 2026

rsarika force-pushed the multi-party-conference-e2e-tests branch from 4e57920 to 2961cf0 Compare March 10, 2026 01:41

rsarika reopened this Mar 10, 2026

rsarika force-pushed the multi-party-conference-e2e-tests branch from 855e4f0 to 3caeeb4 Compare March 10, 2026 01:51

Merge branch 'next' of https://github.com/webex/widgets into multi-pa…

5ae2115

…rty-conference-e2e-tests

akulakum approved these changes Mar 10, 2026

View reviewed changes

rsarika added 3 commits March 10, 2026 12:41

fix: added one more set

6ebd597

fix: flaky tests

6731b01

fix: flaky end task

66e28c3

chatgpt-codex-connector Bot reviewed Mar 10, 2026

View reviewed changes

Comment thread playwright/Utils/taskControlUtils.ts Outdated

rsarika added 2 commits March 10, 2026 15:00

fix: audio flaky

34cd4c8

fix: flaky tests

6812bca

chatgpt-codex-connector Bot reviewed Mar 10, 2026

View reviewed changes

rsarika added 3 commits March 10, 2026 17:29

fix: flaky tests

cbd7978

fix: flaky tests

106494d

fix: flaky tests

1715146

chatgpt-codex-connector Bot reviewed Mar 10, 2026

View reviewed changes

fix: refactor tests

1c36e05

chatgpt-codex-connector Bot reviewed Mar 10, 2026

View reviewed changes

fix: flaky tests

6828c73

Shreyas281299 approved these changes Mar 11, 2026

View reviewed changes

rsarika merged commit 3876709 into webex:next Mar 11, 2026
7 of 8 checks passed


		export type ConferenceSuiteGroup = 'all' \| 'mpc' \| 'transfer-switch' \| 'mpc-transfer' \| 'switch';

		async function setAgentState(page: Page, state: string): Promise<void> {

		await Promise.race([handleStrayTasks(page, validAuxiliaryPage), timeoutPromise]);
		} catch {

		const controlCount = await controls.count().catch(() => 0);

		for (let i = 0; i < controlCount; i++) {

Conversation

rsarika commented Feb 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

COMPLETES #https://jira-eng-sjc12.cisco.com/jira/browse/CAI-7322

This pull request addresses

by making the following changes

The following scenarios were tested

Uh oh!

aws-amplify-us-east-2 Bot commented Feb 18, 2026

Uh oh!

rsarika commented Feb 18, 2026

Uh oh!

chatgpt-codex-connector Bot commented Feb 18, 2026

Uh oh!

akulakum left a comment

Choose a reason for hiding this comment

PR Review: feat(cc-widgets): Add multi-party conference E2E suites for SET_7 and SET_8

Summary

Critical Issues (Must Fix)

Medium Issues

Minor Issues

Documentation Issues

Positive Observations

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

akulakum Feb 19, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Shreyas281299 commented Feb 20, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector Bot Mar 7, 2026

Choose a reason for hiding this comment

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

rsarika commented Feb 18, 2026 •

edited

Loading